Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set use_manageiq true as default #5809

Merged
merged 1 commit into from
Oct 19, 2017

Conversation

enoodle
Copy link
Contributor

@enoodle enoodle commented Oct 19, 2017

It was recently changed to be false, probably by mistake in #5208

This is in line with previous PR to set this as default #1050

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 19, 2017
@enoodle
Copy link
Contributor Author

enoodle commented Oct 19, 2017

Copy link
Contributor

@zgalor zgalor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@yaacov yaacov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link

@enoodle: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/install 2ba986c link /test install
ci/openshift-jenkins/upgrade 2ba986c link /test upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@enoodle enoodle changed the title set use_manageiq as default set use_manageiq true as default Oct 19, 2017
@sdodson sdodson merged commit ca6581d into openshift:master Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants