Removing run_once usage on include_tasks

[jimi-c]

Previously, run_once (and several other options) were silently ignored on include_tasks
and effectively did nothing. As of 2.7/2.8 these invalid options will now raise errors,
so they must be removed.

This was tested against an install of 3.11 originally, so there may be others that were
added after that release.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jimi-c
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mtnbikenc

If they are not already assigned, you can assign the PR to them by writing /assign @mtnbikenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[papr-bot]

Can one of the admins verify this patch?
I understand the following commands:

• bot, add author to whitelist
• bot, test pull request
• bot, test pull request once

[sdodson]

/ok-to-test

[vrutkovs]

As of 2.7/2.8 these invalid options will now raise errors,
so they must be removed.

Is it working fine in 2.6? We don't support ansible 2.7+ yet

[jimi-c]

@vrutkovs Yes it works fine on 2.6 because these invalid options were silently ignored. However, the point is to get it working on the most recent Ansible versions.

[vrutkovs]

Ansible 2.7 install fails on #10368

Maybe its already fixed in 2.7.1?

[mtnbikenc]

Still had install failures for 2.7.0 and 2.7.1. Looking into why they failed.

[jimi-c]

@mtnbikenc odd, the commit we thought fixed this (ansible/ansible#46970) was back-ported and included in 2.7.1. I also did a successful install on AWS using the devel branch which included 1 master/etcd, 3 glusterfs nodes, and 5 worker nodes. Definitely let us know what you find, if we need to back-port something else for 2.7.2.

[sdodson]

@mtnbikenc any reason not to merge this? Even if it's not a complete fix for all possible issues with 2.7 it seems like we should either close or get it merged.

[vrutkovs]

Since we're hardcoding ansible version this PR also needs to require 2.7.1 so that it would be properly tested by CI

[openshift-ci-robot]

@jimi-c: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws	58c3649	link	/test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[vrutkovs]

Master branch is closed! A major refactor is ongoing in devel-40. Changes for 3.x should be made directly to the latest release branch they're relevant to and backported from there.