Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run openshift_version before configuring repositories #10640

Closed
wants to merge 1 commit into from

Conversation

leoluk
Copy link

@leoluk leoluk commented Nov 8, 2018

This fixes #10445.

Correct file is templated:

TASK [openshift_repos : Configure correct origin release repository] ***************************************************************************************************************************************************************************************************************************************************************************************************************************
Thursday 08 November 2018  15:43:08 +0100 (0:00:00.865)       0:00:36.746 ***** 
changed: [oc-dev.marbis.net] => (item=/opt/openshift/roles/openshift_repos/templates/CentOS-OpenShift-Origin310.repo.j2)

TASK [openshift_repos : debug] *****************************************************************************************************************************************************************************************************************************************************************************************************************************************************************
Thursday 08 November 2018  15:43:09 +0100 (0:00:01.172)       0:00:37.918 ***** 
ok: [oc-dev.marbis.net] => {
    "msg": "CentOS-OpenShift-Origin310.repo.j2"
}
$ rm /etc/yum.repos.d/*Origin*
$ ansible-playbook playbooks/prerequisites.yml
[...]
$ ls /etc/yum.repos.d/*Origin*
/etc/yum.repos.d/CentOS-OpenShift-Origin310.repo

We might want to remove the wrongly deployed CentOS-OpenShift-Origin.repo for existing 3.10 installs, otherwise, they will pull 3.11 packages as soon as those are added to the SIG repo.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 8, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leoluk
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mtnbikenc

If they are not already assigned, you can assign the PR to them by writing /assign @mtnbikenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 8, 2018
@vrutkovs
Copy link
Member

vrutkovs commented Nov 8, 2018

/ok-to-test

@openshift-ci-robot openshift-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 8, 2018
@papr-bot
Copy link

papr-bot commented Nov 8, 2018

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2018
Copy link
Contributor

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

I need to look into what this might impact. I'm pretty sure we need information from cluster_facts for openshift_version.

Copy link
Contributor

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, unfortunately this change won't do. We have a chicken and egg problem with 'openshift_current_version' which relies on packages being installed to detect it.

In 3.9 and newer, we only support the current openshift-ansible branch, so we might as well hard-code these centos repo template names to whatever the branch is.

EG, on 3.11, just hard-code to use CentOS-311.repo (or whatever it's named).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CentOS Origin repo template for 3.10 is broken
5 participants