-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run openshift_version before configuring repositories #10640
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: leoluk If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Can one of the admins verify this patch?
|
df0147f
to
d1fedb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
I need to look into what this might impact. I'm pretty sure we need information from cluster_facts for openshift_version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, unfortunately this change won't do. We have a chicken and egg problem with 'openshift_current_version' which relies on packages being installed to detect it.
In 3.9 and newer, we only support the current openshift-ansible branch, so we might as well hard-code these centos repo template names to whatever the branch is.
EG, on 3.11, just hard-code to use CentOS-311.repo (or whatever it's named).
This fixes #10445.
Correct file is templated:
We might want to remove the wrongly deployed CentOS-OpenShift-Origin.repo for existing 3.10 installs, otherwise, they will pull 3.11 packages as soon as those are added to the SIG repo.