Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-3.10] [release-3.11] Make same timezone with running hosts #11373

Merged
merged 1 commit into from
Apr 24, 2019
Merged

[release-3.10] [release-3.11] Make same timezone with running hosts #11373

merged 1 commit into from
Apr 24, 2019

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #11160

/assign sdodson

@bysnupy
Make same timezone with running hosts
849a674 
Master static pods are always running with UTC timezone, it would be not same timezone with worker nodes. It causes potential issues of time dependent works.
- Fix: https://bugzilla.redhat.com/show_bug.cgi?id=1674170
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 19, 2019
Merged
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 19, 2019
@sdodson
Copy link
Member

sdodson commented Mar 19, 2019

/lgtm
/hold
Need to investigate what's up with openshift/cluster-monitoring-operator#279 before we backport

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 19, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2019
@sdodson
Copy link
Member

sdodson commented Apr 23, 2019 •
edited
Loading

/hold cancel
Decision was that kube-state-metrics needs to mount /etc/localtime as well in 3.x. 4.x will be all UTC.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2019
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 84caccb into openshift:release-3.10 Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@sdodson sdodson Awaiting requested review from sdodson

Assignees

@sdodson sdodson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@openshift-cherrypick-robot @sdodson @openshift-ci-robot @openshift-bot @openshift-merge-robot @bysnupy