Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1793078: Fix machine config apply on upgrade #12069

Merged
merged 2 commits into from
Jan 20, 2020
Merged

Bug 1793078: Fix machine config apply on upgrade #12069

merged 2 commits into from
Jan 20, 2020

Conversation

mtnbikenc
Copy link
Member

@mtnbikenc mtnbikenc commented Jan 17, 2020 •
edited
Loading

  • Use local pull-secret for pulling mcd image
  • Use node desiredConfig to apply machine configuration that MCD expects
  • Use proxy if defined

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 17, 2020
@mtnbikenc mtnbikenc mentioned this pull request Jan 17, 2020
Merged
@mtnbikenc mtnbikenc changed the title Fix machine config apply on upgrade [WIP] Fix machine config apply on upgrade Jan 17, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2020
@mtnbikenc
Fix machine config apply on upgrade
a3d181e 
* Use local pull-secret for pulling mcd image
* Use node desiredConfig to apply machine configuration that MCD expects
* Use proxy if defined
@mtnbikenc mtnbikenc changed the title [WIP] Fix machine config apply on upgrade Fix machine config apply on upgrade Jan 20, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2020
@mtnbikenc mtnbikenc changed the title Fix machine config apply on upgrade Bug 1793078: Fix machine config apply on upgrade Jan 20, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 20, 2020
@openshift-ci-robot
Copy link

@mtnbikenc: This pull request references Bugzilla bug 1793078, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1793078: Fix machine config apply on upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtnbikenc
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot
Copy link

@mtnbikenc: This pull request references Bugzilla bug 1793078, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 20, 2020
@sdodson
Copy link
Member

sdodson commented Jan 20, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtnbikenc, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8192923 into openshift:master Jan 20, 2020
@openshift-ci-robot
Copy link

@mtnbikenc: All pull requests linked via external trackers have merged. Bugzilla bug 1793078 has been moved to the MODIFIED state.

In response to this:

Bug 1793078: Fix machine config apply on upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtnbikenc mtnbikenc deleted the fix-config-apply branch January 20, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstuever jstuever Awaiting requested review from jstuever

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

Assignees

@sdodson sdodson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mtnbikenc @openshift-ci-robot @sdodson @openshift-merge-robot