-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-29527: Install ose-aws-ecr-image-credential-provider #12486
Conversation
This is a new package required since 4.14.11
@sdodson: This pull request references Jira Issue OCPBUGS-29527, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm Need to see tests pass but I approve of the addition |
/jira refresh |
@sdodson: This pull request references Jira Issue OCPBUGS-29527, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira-clone release-4.15 |
/jira cherrypick OCPBUGS-29527 |
Looks like those failures are unique to master branch, looking to open 4.15 PR verify it passes there then override here. |
/approve |
4.15 is also permafailing: https://issues.redhat.com/browse/CORS-3271 perhaps we can get pre-merge testing? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, patrickdillon, sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Actually, it looks possible our permafailing may be due to the bug being fixed here.
|
testing 4.15 in #12488 |
/retest |
/label acknowledge-critical-fixes-only |
Still lacking crio 1.29 in repos for this job |
/override ci/prow/e2e-aws-workers-rhel8 |
@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws-workers-rhel8 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sdodson: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@sdodson: Jira Issue OCPBUGS-29527: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-29527 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This is a new package required since 4.14.11