Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-29527: Install ose-aws-ecr-image-credential-provider #12486

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

sdodson
Copy link
Member

@sdodson sdodson commented Feb 15, 2024

This is a new package required since 4.14.11

This is a new package required since 4.14.11
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 15, 2024
@openshift-ci-robot
Copy link

@sdodson: This pull request references Jira Issue OCPBUGS-29527, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a new package required since 4.14.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoelSpeed
Copy link

/lgtm

Need to see tests pass but I approve of the addition

@sdodson
Copy link
Member Author

sdodson commented Feb 15, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 15, 2024
@openshift-ci-robot
Copy link

@sdodson: This pull request references Jira Issue OCPBUGS-29527, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2024
@sdodson
Copy link
Member Author

sdodson commented Feb 15, 2024

/jira-clone release-4.15

@sdodson
Copy link
Member Author

sdodson commented Feb 15, 2024

/jira cherrypick OCPBUGS-29527

@sdodson
Copy link
Member Author

sdodson commented Feb 15, 2024

Looks like those failures are unique to master branch, looking to open 4.15 PR verify it passes there then override here.

@patrickdillon
Copy link
Contributor

/approve

@patrickdillon
Copy link
Contributor

Looks like those failures are unique to master branch, looking to open 4.15 PR verify it passes there then override here.

4.15 is also permafailing: https://issues.redhat.com/browse/CORS-3271

perhaps we can get pre-merge testing?

Copy link
Contributor

openshift-ci bot commented Feb 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, patrickdillon, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 195af48 and 2 for PR HEAD 2956dc0 in total

@patrickdillon
Copy link
Contributor

patrickdillon commented Feb 15, 2024

Looks like those failures are unique to master branch, looking to open 4.15 PR verify it passes there then override here.

4.15 is also permafailing: https://issues.redhat.com/browse/CORS-3271

perhaps we can get pre-merge testing?

Actually, it looks possible our permafailing may be due to the bug being fixed here.

"stderr": "Warning: The unit file, source configuration file or drop-ins of kubelet.service changed on disk. Run 'systemctl daemon-reload' to reload units.",
"stderr_lines": [
    "Warning: The unit file, source configuration file or drop-ins of kubelet.service changed on disk. Run 'systemctl daemon-reload' to reload units."
],
"stdout": "● kubelet.service - Kubernetes Kubelet\n   Loaded: loaded (/etc/systemd/system/kubelet.service; enabled; vendor preset: disabled)\n  Drop-In: /etc/systemd/system/kubelet.service.d\n           └─01-kubens.conf, 10-mco-default-madv.conf, 20-logging.conf, 20-node-env.conf\n   Active: activating (auto-restart) (Result: exit-code) since Thu 2024-02-15 04:48:35 UTC; 1s ago\n  Process: 6828 ExecStart=/usr/local/bin/kubenswrapper /usr/bin/kubelet --config=/etc/kubernetes/kubelet.conf --bootstrap-kubeconfig=/etc/kubernetes/kubeconfig --kubeconfig=/var/lib/kubelet/kubeconfig --container-runtime-endpoint=/var/run/crio/crio.sock --runtime-cgroups=/system.slice/crio.service --node-labels=node-role.kubernetes.io/worker,node.openshift.io/os_id=${ID} --node-ip=${KUBELET_NODE_IP} --minimum-container-ttl-duration=6m0s --volume-plugin-dir=/etc/kubernetes/kubelet-plugins/volume/exec --cloud-provider=external **--image-credential-provider-bin-dir=/usr/libexec/kubelet-image-credential-provider-plugins --image-credential-provider-config=/etc/kubernetes/credential-providers/ecr-credential-provider.yaml** --hostname-override=${KUBELET_NODE_NAME} --provider-id=${KUBELET_PROVIDERID} --pod-infra-container-image=quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:6068d844068ad78d7dc11129962fbd562eff5a2b2df82f1342dae2dae1817542 --system-reserved=cpu=${SYSTEM_RESERVED_CPU},memory=${SYSTEM_RESERVED_MEMORY},ephemeral-storage=${SYSTEM_RESERVED_ES} --v=${KUBELET_LOG_LEVEL} (code=exited, status=1/FAILURE)\n  Process: 6827 ExecStartPre=/bin/rm -f /var/lib/kubelet/memory_manager_state (code=exited, status=0/SUCCESS)\n  Process: 6825 ExecStartPre=/bin/rm -f /var/lib/kubelet/cpu_manager_state (code=exited, status=0/SUCCESS)\n  Process: 6823 ExecStartPre=/bin/mkdir --parents /etc/kubernetes/manifests (code=exited, status=0/SUCCESS)\n Main PID: 6828 (code=exited, status=1/FAILURE)\n      CPU: 85ms\n\nFeb 15 04:48:35 ip-10-0-93-44.us-west-1.compute.internal systemd[1]: kubelet.service: Consumed 85ms CPU time",

@patrickdillon
Copy link
Contributor

testing 4.15 in #12488

@sdodson
Copy link
Member Author

sdodson commented Feb 16, 2024

/retest

@sdodson
Copy link
Member Author

sdodson commented Feb 16, 2024

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Feb 16, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 08782ff and 1 for PR HEAD 2956dc0 in total

@sdodson
Copy link
Member Author

sdodson commented Feb 16, 2024

Still lacking crio 1.29 in repos for this job

@sdodson
Copy link
Member Author

sdodson commented Feb 16, 2024

/override ci/prow/e2e-aws-workers-rhel8

Copy link
Contributor

openshift-ci bot commented Feb 16, 2024

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws-workers-rhel8

In response to this:

/override ci/prow/e2e-aws-workers-rhel8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Feb 16, 2024

@sdodson: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b0ba95a into openshift:master Feb 16, 2024
5 checks passed
@openshift-ci-robot
Copy link

@sdodson: Jira Issue OCPBUGS-29527: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29527 has been moved to the MODIFIED state.

In response to this:

This is a new package required since 4.14.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants