Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-29561: Install ose-aws-ecr-image-credential-provider #12488

Conversation

patrickdillon
Copy link
Contributor

This is a new package required since 4.14.11

/jira cherry-pick OCPBUGS-29527

@openshift-ci openshift-ci bot requested a review from barbacbd February 15, 2024 20:20
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2024
@patrickdillon
Copy link
Contributor Author

/jira cherry-pick OCPBUGS-29527

@openshift-ci-robot
Copy link

@patrickdillon: Jira Issue OCPBUGS-29527 has been cloned as Jira Issue OCPBUGS-29561. Will retitle bug to link to clone.
/retitle OCPBUGS-29561: Install ose-aws-ecr-image-credential-provider

In response to this:

/jira cherry-pick OCPBUGS-29527

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title Install ose-aws-ecr-image-credential-provider OCPBUGS-29561: Install ose-aws-ecr-image-credential-provider Feb 15, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 15, 2024
@openshift-ci-robot
Copy link

@patrickdillon: This pull request references Jira Issue OCPBUGS-29561, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a new package required since 4.14.11

/jira cherry-pick OCPBUGS-29527

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from gpei February 15, 2024 20:22
@patrickdillon patrickdillon changed the base branch from master to release-4.15 February 15, 2024 22:16
@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 15, 2024
@openshift-ci-robot
Copy link

@patrickdillon: This pull request references Jira Issue OCPBUGS-29561, which is invalid:

  • expected the bug to target either version "4.15." or "openshift-4.15.", but it targets "4.16.0" instead
  • expected dependent Jira Issue OCPBUGS-29527 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This is a new package required since 4.14.11

/jira cherry-pick OCPBUGS-29527

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@patrickdillon
Copy link
Contributor Author

/hold

Need to fix base branch

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2024
This is a new package required since 4.14.11
@patrickdillon patrickdillon force-pushed the ose-aws-ecr-image-credential-provider branch from 0d7d799 to e221075 Compare February 15, 2024 22:26
@patrickdillon
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2024
@patrickdillon
Copy link
Contributor Author

/retest

Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2024
Copy link
Contributor

openshift-ci bot commented Feb 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [barbacbd,patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson sdodson added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 16, 2024
@sdodson
Copy link
Member

sdodson commented Feb 16, 2024

Applying all necessary labels for this fix which needs to be backported to 4.14. it would ideally also make 4.15 GA but RHEL workers are small percentage of fleet and likely that this problem goes unnoticed in 4.15 for a while

Copy link
Contributor

openshift-ci bot commented Feb 16, 2024

@patrickdillon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1c9b99e into openshift:release-4.15 Feb 16, 2024
5 checks passed
@openshift-ci-robot
Copy link

@patrickdillon: Jira Issue OCPBUGS-29561: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29561 has been moved to the MODIFIED state.

In response to this:

This is a new package required since 4.14.11

/jira cherry-pick OCPBUGS-29527

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sdodson
Copy link
Member

sdodson commented Feb 17, 2024

/cherry-pick release-4.14

@openshift-cherrypick-robot

@sdodson: new pull request created: #12491

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants