Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics improvements #2052

Merged
merged 12 commits into from
Aug 25, 2016
Merged

Metrics improvements #2052

merged 12 commits into from
Aug 25, 2016

Conversation

sdodson
Copy link
Member

@sdodson sdodson commented Jun 16, 2016 •
edited
Loading

  • Metrics deployment is currently disabled by default. Enable it by setting openshift_hosted_metrics_deploy=true
  • Metrics currently only supports one single cassandra node. This has been shown to be sufficient for up to 1000 pods. If you require multiple cassandra nodes you need to deploy metrics manually and ensure that you have enough persistent volumes to match your cassandra node count.
  • If you're using the nfs role to automatically provision exports you may add the following
    • openshift_hosted_metrics_storage_kind=nfs
    • openshift_hosted_metrics_storage_volume_name=metrics
    • openshift_hosted_metrics_storage_volume_size=10Gi

@sdodson sdodson force-pushed the metrics branch 2 times, most recently from db36b41 to 67302b7 Compare July 20, 2016 15:03
@sdodson sdodson force-pushed the metrics branch 3 times, most recently from e72519b to 455d21c Compare August 10, 2016 19:08
@sdodson sdodson force-pushed the metrics branch 2 times, most recently from 30036f2 to 5c2c11f Compare August 17, 2016 18:32
sdodson
sdodson reviewed Aug 17, 2016
View reviewed changes
roles/openshift_storage_nfs/tasks/main.yml
# state: absent
# with_items: exports_out.stdout.lines
# when: exports_out.rc == 0
#
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abutcher i imagine there's a simpler way to do this, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not unless we just remove the ones we're adding?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdodson @abutcher considering that we don't really consider the nfs host to be mean for production, I don't really see an issue with not cleaning up after ourselves here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it figured out, I'll deploy /etc/exports.d/openshift-ansible.exports and remove any entries that exist there from /etc/exports. That way the uninstall playbooks can nuke /etc/exports.d/openshift-ansible.exports without fear of deleting something else even though nothing else will exist in most cases. I'm just running into this because i'm installing, uninstalling, installing...

@sdodson sdodson force-pushed the metrics branch 3 times, most recently from 496ec8c to 4f722d4 Compare August 23, 2016 13:49
@sdodson
Copy link
Member Author

sdodson commented Aug 23, 2016

@detiber ok i think i'm done with all functional changes.

@sdodson sdodson changed the title [WIP] Metrics improvements Metrics improvements Aug 23, 2016
@sdodson
Copy link
Member Author

sdodson commented Aug 23, 2016

aos-ci-test

@sdodson sdodson force-pushed the metrics branch 3 times, most recently from eda0653 to bedb7ad Compare August 23, 2016 14:08
@openshift-bot
Copy link

bedb7ad - State: success - All Test Contexts: aos-ci-jenkins/OS_unit_tests - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-2-unit-tests-192/bedb7ad2ac11cb283f20fdea48186d07e92e3559.txt

@openshift-bot
Copy link

bedb7ad - State: success - All Test Contexts: "aos-ci-jenkins/OS_3.2_NOT_containerized, aos-ci-jenkins/OS_3.2_NOT_containerized_e2e_tests" - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-3-test-matrix-CONTAINERIZED=_NOT_containerized,OSE_VER=3.2,PYTHON=System-CPython-2.7,TOPOLOGY=openshift-cluster,TargetBranch=master,nodes=openshift-ansible-slave-212/bedb7ad2ac11cb283f20fdea48186d07e92e3559.txt

@openshift-bot
Copy link

bedb7ad - State: success - All Test Contexts: "aos-ci-jenkins/OS_3.2_containerized, aos-ci-jenkins/OS_3.2_containerized_e2e_tests" - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-3-test-matrix-CONTAINERIZED=_containerized,OSE_VER=3.2,PYTHON=System-CPython-2.7,TOPOLOGY=openshift-cluster-containerized,TargetBranch=master,nodes=openshift-ansible-slave-212/bedb7ad2ac11cb283f20fdea48186d07e92e3559.txt

@abutcher
Copy link
Member

Pylint errors:

************* Module openshift_facts
C:469, 0: Exactly one space required around assignment
    metrics_selector="region=metrics"
                    ^ (bad-whitespace)
C:470, 0: Exactly one space required around assignment
    logging_selector="region=logging"
                    ^ (bad-whitespace)
W:469, 4: Unused variable 'metrics_selector' (unused-variable)
W:470, 4: Unused variable 'logging_selector' (unused-variable)

@sdodson sdodson force-pushed the metrics branch 2 times, most recently from 75dba8f to 46051fd Compare August 24, 2016 18:35
@sdodson
Copy link
Member Author

sdodson commented Aug 24, 2016

aos-ci-test

@sdodson
Copy link
Member Author

sdodson commented Aug 24, 2016

aos-ci-test

@openshift-bot
Copy link

3f2d71a - State: success - All Test Contexts: aos-ci-jenkins/OS_unit_tests - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-2-unit-tests-202/3f2d71a1bfb589778733dd8eb0ccd6b1dac31d79.txt

@openshift-bot
Copy link

3f2d71a - State: success - All Test Contexts: "aos-ci-jenkins/OS_3.2_NOT_containerized, aos-ci-jenkins/OS_3.2_NOT_containerized_e2e_tests" - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-3-test-matrix-CONTAINERIZED=_NOT_containerized,OSE_VER=3.2,PYTHON=System-CPython-2.7,TOPOLOGY=openshift-cluster,TargetBranch=master,nodes=openshift-ansible-slave-222/3f2d71a1bfb589778733dd8eb0ccd6b1dac31d79.txt

@openshift-bot
Copy link

3f2d71a - State: success - All Test Contexts: "aos-ci-jenkins/OS_3.2_containerized, aos-ci-jenkins/OS_3.2_containerized_e2e_tests" - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-3-test-matrix-CONTAINERIZED=_containerized,OSE_VER=3.2,PYTHON=System-CPython-2.7,TOPOLOGY=openshift-cluster-containerized,TargetBranch=master,nodes=openshift-ansible-slave-222/3f2d71a1bfb589778733dd8eb0ccd6b1dac31d79.txt

@sdodson sdodson merged commit d08a872 into openshift:master Aug 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sdodson @openshift-bot @abutcher @detiber