Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix master services list for etcd migration #6428

Merged
merged 1 commit into from
Dec 11, 2017

Conversation

sdodson
Copy link
Member

@sdodson sdodson commented Dec 11, 2017

We require that folks migrate to etcd v3 storage before upgrading to 3.7 and the 3.7 upgrade documentation also calls this out. So there's an incredibly strong chance that the 3.7 playbooks will be used to migrate from etcd v2 to v3. However in 3.6 if you had a single master it likely did not use the ha services. So check for that, this is slightly simplified logic copied from release-3.6 branch.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 11, 2017
@sdodson
Copy link
Member Author

sdodson commented Dec 11, 2017

/assign mtnbikenc

@sdodson
Copy link
Member Author

sdodson commented Dec 11, 2017

I've not made this change on master and I wonder if we should consider removing the etcd migration playbooks there. We require that the migration be completed prior to upgrading to 3.7 so they're no longer necessary.

Copy link
Member

@mtnbikenc mtnbikenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2017
@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2017

@sdodson: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install_crio 2005bc2 link /test crio

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit df5f620 into openshift:release-3.7 Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants