Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1529575] Ensure etcd.conf variables are updated during upgrade #7711

Merged
merged 2 commits into from Apr 3, 2018
Merged

[1529575] Ensure etcd.conf variables are updated during upgrade #7711

merged 2 commits into from Apr 3, 2018

Conversation

mtnbikenc
Copy link
Member

In certain cases, an existing etcd installation may not have updated configuration variables causing services to fail. This ensures the etcd.conf file is verified during upgrades to ensure all variables are set as expected.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1529575

@mtnbikenc mtnbikenc added the kind/bug Categorizes issue or PR as related to a bug. label Mar 29, 2018
@mtnbikenc mtnbikenc self-assigned this Mar 29, 2018
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 29, 2018
@sdodson
Copy link
Member

sdodson commented Mar 29, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2018
michaelgugino
michaelgugino approved these changes Mar 29, 2018
View reviewed changes
Copy link
Contributor

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mtnbikenc
Copy link
Member Author

/retest

@mtnbikenc mtnbikenc changed the title Ensure etcd.conf variables are updated during upgrade [1529575] Ensure etcd.conf variables are updated during upgrade Mar 30, 2018
@mtnbikenc
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 2, 2018 •
edited

@mtnbikenc: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install_crio 4a79a7e link /test crio

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@smarterclayton
Copy link
Contributor

/retest

@smarterclayton
Copy link
Contributor

bot, retest this please

@smarterclayton
Copy link
Contributor

/skip

@openshift-merge-robot openshift-merge-robot merged commit 35f5fb9 into openshift:master Apr 3, 2018
@mtnbikenc
Copy link
Member Author

/cherrypick release-3.9

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 3, 2018
Merged
@openshift-cherrypick-robot
Copy link

@mtnbikenc: new pull request created: #7754

In response to this:

/cherrypick release-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtnbikenc
Copy link
Member Author

/cherrypick release-3.7

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 3, 2018
Closed
@openshift-cherrypick-robot
Copy link

@mtnbikenc: new pull request created: #7755

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtnbikenc
Copy link
Member Author

/cherrypick release-3.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 3, 2018
Closed
@openshift-cherrypick-robot
Copy link

@mtnbikenc: new pull request created: #7756

In response to this:

/cherrypick release-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Apr 4, 2018
Merged
Merged
@mtnbikenc mtnbikenc deleted the fix-1529575 branch April 4, 2018 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelgugino michaelgugino michaelgugino approved these changes

@sdodson sdodson Awaiting requested review from sdodson

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

Assignees

@sdodson sdodson

@michaelgugino michaelgugino

@mtnbikenc mtnbikenc

Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mtnbikenc @sdodson @openshift-ci-robot @smarterclayton @openshift-cherrypick-robot @michaelgugino @openshift-merge-robot