Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] Add nfs storage_kind check to sanity_checks #7920

Merged

Conversation

michaelgugino
Copy link
Contributor

This commit adds check to ensure that no components are using
*storage_kind='nfs' unless users opt into unsupported
configurations using openshift_enable_unsupported_configurations=True.

This is necessary because components need file system capabilities
that nfs cannot provide.

Implements: https://bugzilla.redhat.com/show_bug.cgi?id=1416639
(cherry picked from commit 70b4b94)

This commit adds check to ensure that no components are using
*storage_kind='nfs' unless users opt into unsupported
configurations using openshift_enable_unsupported_configurations=True.

This is necessary because components need file system capabilities
that nfs cannot provide.

Implements: https://bugzilla.redhat.com/show_bug.cgi?id=1416639
(cherry picked from commit 70b4b94)
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 11, 2018
@michaelgugino michaelgugino changed the title Add nfs storage_kind check to sanity_checks [3.9] Add nfs storage_kind check to sanity_checks Apr 11, 2018
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 11, 2018

@michaelgugino: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/system-containers 7780e7a link /test system-containers
ci/openshift-jenkins/gcp 7780e7a link /test gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sdodson
Copy link
Member

sdodson commented Apr 12, 2018

/lgtm

@sdodson
Copy link
Member

sdodson commented Apr 12, 2018

/retest

@sdodson sdodson merged commit 7efb02f into openshift:release-3.9 Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants