Remove etcd_version

[vrutkovs]

etcd version can no longer be specified in etcd_version.

This parameter never worked properly, as for various platforms a minimum version was required. Instead of some outdated version the latest etcd should always be used

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1538989

[vrutkovs]

/test gcp

[michaelgugino]

I'm not sure how I feel about this. It looks like the parameter would work in some cases.

[sdodson]

We don't exert any control over etcd version other than when we upgrade it we do so in a step wise manner. This definitely didn't work during upgrades and if we were to make it work during upgrades we'd have to add a lot of conditional logic to ensure that it's both stepwise and how to handle the situation where we'd have to downgrade in order to get the version requested.

Therefore I think we should just remove this.

[michaelgugino]

We don't exert any control over etcd version other than when we upgrade it we do so in a step wise manner. This definitely didn't work during upgrades and if we were to make it work during upgrades we'd have to add a lot of conditional logic to ensure that it's both stepwise and how to handle the situation where we'd have to downgrade in order to get the version requested.

I do think we need to refactor how etcd upgrades take place (I believe origin is currently broken in this regard).

In the mean time, I'm okay with removing it if that's desired.

[michaelgugino]

/lgtm

[mtnbikenc]

/lgtm

[sdodson]

/test gcp

[vrutkovs]

/cherrypick release-3.9

[openshift-cherrypick-robot]

@vrutkovs: #7992 failed to apply on top of branch "release-3.9":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	inventory/hosts.example
M	roles/etcd/tasks/certificates/fetch_server_certificates_from_ca.yml
A	roles/etcd/tasks/rpm.yml
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): roles/etcd/tasks/rpm.yml deleted in HEAD and modified in Remove etcd_version. Version Remove etcd_version of roles/etcd/tasks/rpm.yml left in tree.
Auto-merging roles/etcd/tasks/certificates/fetch_server_certificates_from_ca.yml
Auto-merging inventory/hosts.example
Patch failed at 0001 Remove etcd_version

In response to this:

/cherrypick release-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.