Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1575508 - CRD file has the wrong name #8272

Merged
merged 1 commit into from
May 8, 2018
Merged

Bug 1575508 - CRD file has the wrong name #8272

merged 1 commit into from
May 8, 2018

Conversation

shawn-hurley
Copy link
Contributor

No description provided.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shawn-hurley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 4, 2018
@shawn-hurley
Copy link
Contributor Author

shawn-hurley commented May 5, 2018 •
edited
Loading

/retest

@vrutkovs
Copy link
Member

vrutkovs commented May 7, 2018

bot, retest this please

@shawn-hurley
Copy link
Contributor Author

/retest

@shawn-hurley shawn-hurley changed the title Bug 1566924 - CRD file has the wrong name Bug 1575508 - CRD file has the wrong name May 7, 2018
@shawn-hurley
Copy link
Contributor Author

bot, retest this please

michaelgugino
michaelgugino suggested changes May 7, 2018
View reviewed changes
Copy link
Contributor

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the git commit message with a description of the change and a link to the BZ.

@shawn-hurley
Copy link
Contributor Author

/retest

@shawn-hurley
Copy link
Contributor Author

bot, retest this please

@sdodson
Copy link
Member

sdodson commented May 8, 2018

/retest

@sdodson
Copy link
Member

sdodson commented May 8, 2018

bot, retest this please

1 similar comment
@shawn-hurley
Copy link
Contributor Author

bot, retest this please

michaelgugino
michaelgugino approved these changes May 8, 2018
View reviewed changes
Copy link
Contributor

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2018
@michaelgugino
Copy link
Contributor

/cherrypick release-3.9

@openshift-cherrypick-robot
Copy link

@michaelgugino: once the present PR merges, I will cherry-pick it on top of release-3.9 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@michaelgugino
Copy link
Contributor

/cherrypick release-3.7

@openshift-cherrypick-robot
Copy link

@michaelgugino: once the present PR merges, I will cherry-pick it on top of release-3.7 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@michaelgugino michaelgugino merged commit 70fda8e into openshift:master May 8, 2018
@openshift-cherrypick-robot
Copy link

@michaelgugino: #8272 failed to apply on top of branch "release-3.9":

error: mode change for roles/ansible_service_broker/files/bundlebindings.automationbroker.io, which is not in current HEAD
error: could not build fake ancestor
Patch failed at 0001 Bug 1575508 - typo in file name during a rename.

In response to this:

/cherrypick release-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@michaelgugino: #8272 failed to apply on top of branch "release-3.7":

error: mode change for roles/ansible_service_broker/files/bundlebindings.automationbroker.io, which is not in current HEAD
error: could not build fake ancestor
Patch failed at 0001 Bug 1575508 - typo in file name during a rename.

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelgugino michaelgugino michaelgugino approved these changes

@dymurray dymurray Awaiting requested review from dymurray

Assignees

@michaelgugino michaelgugino

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shawn-hurley @openshift-ci-robot @vrutkovs @sdodson @michaelgugino @openshift-cherrypick-robot