[BZ 1570583] Install metrics components in different namespace

[jsanda]

Metrics components can no longer go in openshift-infra. This commit puts them in openshift-metrics.

@ewolinetz can you please review this?

I am operating under the assumption that additional changes will be needed, but things seem to be working after my initial smoke test.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsanda

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• roles/openshift_metrics/OWNERS [jsanda]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ewolinetz]

@jsanda it is still valid for HOSA to still be installed in default correct?

Looks like this file also needs to be updated:

openshift-ansible/roles/openshift_metrics/templates/hawkular_openshift_agent_cm.j2

Lines 15 to 19 in 6790ffa

	url: https://hawkular-metrics.openshift-infra.svc.cluster.local
	credentials:
	username: secret:openshift-infra/hawkular-metrics-account/hawkular-metrics.username
	password: secret:openshift-infra/hawkular-metrics-account/hawkular-metrics.password
	ca_cert_file: secret:openshift-infra/hawkular-metrics-certs/ca.crt

[ewolinetz]

openshift-ansible/roles/openshift_metrics/templates/hawkular_openshift_agent_cm.j2

Lines 15 to 19 in 6790ffa

	url: https://hawkular-metrics.openshift-infra.svc.cluster.local
	credentials:
	username: secret:openshift-infra/hawkular-metrics-account/hawkular-metrics.username
	password: secret:openshift-infra/hawkular-metrics-account/hawkular-metrics.password
	ca_cert_file: secret:openshift-infra/hawkular-metrics-certs/ca.crt

Can you replace the instances of openshift-infra there with {{ openshift_metrics_project }} ?

[jsanda]

I will make the updates. With respect to HOSA, there is actually another ticket, BZ 1562210, to remove it.

[juzhao]

Prometheus and garbage collection are also installed under openshift-metrics project, will our change affect their functions?

[theute]

Will it be ok with existing users who upgrade from older versions ?
What impact on them ? I guess API URL will change at least, other impacts ?

[jsanda]

@ewolinetz I updated hawkular_openshift_agent_cm.j2. With respect to @juzhao's question:

Prometheus and garbage collection are also installed under openshift-metrics project, will our change affect their functions?

Should I change the default value of openshift_metrics_project?

[ewolinetz]

@jsanda how likely is it that prometheus and hawkular would both be installed at the same time? Is there any negative repercussions from having them installed/running in the same project?

With regards to @theute 's question, I think we should do something similar to what we did for logging, which was try to detect if there is a hawkular stack already installed in its current location, if so then we would maintain configuring in that project, but possibly warn users that they should migrate? Unfortunately there isn't a way to migrate persistent volumes to another project, otherwise we could just do that.

[jwforres]

long term the prometheus stack will be installed in openshift-monitoring not openshift-metrics

as far as both hawkular and prometheus being installed during 3.10 - it is definitely possible for customers that are wanting to try out prom for cluster monitoring

[jsanda]

This PR is being replaced by PR 8649.