Unify cluster-monitoring install variables #9727
Conversation
openshift-ci-robot
added
the
size/XS
|
Lets also add an entry to |
openshift-ci-robot
added
size/M
|
@vrutkovs great point. I added a commit describing how to disable it as well as the variables that are intended to be used by users. Let me know what you think. |
inventory/hosts.example
Outdated
| # to run components of cluster-monitoring on and the configuration to use for | ||
| # the Prometheus Alertmanager. | ||
| # | ||
| # openshift_cluster_monitoring_operator_prometheus_storage_capacity: "50Gi" |
There was a problem hiding this comment.
These should be in INI format, so openshift_cluster_monitoring_operator_prometheus_storage_capacity="50Gi"
The switch to YAML is planned, but we'll take care of it
inventory/hosts.example
Outdated
| # openshift_cluster_monitoring_operator_prometheus_storage_capacity: "50Gi" | ||
| # openshift_cluster_monitoring_operator_alertmanager_storage_capacity: "2Gi" | ||
| # openshift_cluster_monitoring_operator_node_selector: "{{ openshift_hosted_infra_selector | default('node-role.kubernetes.io/infra=true') | map_from_pairs }}" | ||
| # openshift_cluster_monitoring_operator_alertmanager_config: |+ |
There was a problem hiding this comment.
This probably should be dropped - its too complex to rewrite in INI format and probably should go to openshift-docs instead
brancz
force-pushed
the
unify-cluster-mon-vars
branch
from
ddddb2a
to
626ba1c
Compare
openshift-ci-robot
added
size/S
|
@vrutkovs updated. PTAL. |
|
Does this PR add deploying the monitoring stack by default only for upgrades or does it also work when running the I traced back the playbooks a little bit and only saw that this being run when upgrading to 3.11. The cluster monitoring stack should always be installed with upgrades to 3.11, but also when installing a complete new 3.11 OCP cluster. Just want to make sure that it is covered as well. |
|
@sichvoge Good point, currently it would only install monitoring on upgrades only |
|
Thanks for letting me know where to add that I was under the impression this is the only place, still trying to find my way around this repo. Will update! |
brancz
force-pushed
the
unify-cluster-mon-vars
branch
from
626ba1c
to
342f5dc
Compare
brancz
force-pushed
the
unify-cluster-mon-vars
branch
from
342f5dc
to
64f19cf
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brancz, sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Closes https://bugzilla.redhat.com/show_bug.cgi?id=1619505
Cluster monitoring is intended to be installed by default starting with 3.11, this PR unifies the previously two variables to control installing cluster-monitoring to one called
openshift_cluster_monitoring_operator_install, and sets it by default totrue.Let me know if this is the idiomatic way to do it.
cc @sdodson @vrutkovs @smarterclayton