Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-3.10] Don't set reclaim policy to empty string #9759

Merged
merged 1 commit into from Aug 29, 2018
Merged

[release-3.10] Don't set reclaim policy to empty string #9759

merged 1 commit into from Aug 29, 2018

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #9752

/assign michaelgugino

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 24, 2018
Merged
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 24, 2018
@wongma7 wongma7 mentioned this pull request Aug 28, 2018
Merged
@wongma7
Copy link
Contributor

wongma7 commented Aug 28, 2018

/assign @michaelgugino
we need #9810 and #9759 cherry-picked into 3.10 to fix https://bugzilla.redhat.com/show_bug.cgi?id=1623234

@sdodson
Copy link
Member

sdodson commented Aug 28, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2018
@sdodson
Copy link
Member

sdodson commented Aug 28, 2018

You mean we need #9759 and #9810 which are backports of #9752 and #9781 respectively?

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/gcp ceb0cf5 link /test gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wongma7
Copy link
Contributor

wongma7 commented Aug 28, 2018 •
edited

@sdodson yep, thanks

@sdodson sdodson merged commit 436498a into openshift:release-3.10 Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelgugino michaelgugino Awaiting requested review from michaelgugino

@sdodson sdodson Awaiting requested review from sdodson

Assignees

@sdodson sdodson

@michaelgugino michaelgugino

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@openshift-cherrypick-robot @wongma7 @sdodson @openshift-ci-robot @michaelgugino