Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure default StorageClass reclaimPolicy is set to nil instead of emptystring when reclaim_policy undefined #9781

Merged
merged 1 commit into from Aug 28, 2018

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Aug 27, 2018

Attempt to fix #9340 again.

Thank you Clayton for finding ansible/ansible#44503. I've added to the integration to ensure that reclaim_policy: "{{ undefined_variable | default(omit, True) }}" results in storageClass.reclaimPolicy being nil then defaulted by openshift to Delete. I am still figuring out how to test this with ansible locally but the integration test will suffice in the meantime I tested it locally and it works as expected.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 27, 2018
@wongma7
Copy link
Contributor Author

wongma7 commented Aug 27, 2018

do the integration tests run with CI? doesn't look like it

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 27, 2018
@vrutkovs
Copy link
Member

/lgtm

Integration tests are being run, see ci/prow/gcp

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrutkovs, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2018
@openshift-merge-robot openshift-merge-robot merged commit d469267 into openshift:master Aug 28, 2018
@wongma7
Copy link
Contributor Author

wongma7 commented Aug 28, 2018

/cherrypick release-3.10

@openshift-cherrypick-robot

@wongma7: new pull request created: #9810

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StorageClass reclaimPolicy is set to "" by default instead of None/nil
5 participants