Bug 1777337: employ k8s label value validation when creating build pod build label… #72
Conversation
|
@gabemontero: This pull request references Bugzilla bug 1777337, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
|
/assign @adambkaplan |
|
non-build related failures in e2e-aws /test e2e-aws |
|
/test e2e-aws |
|
bump @adambkaplan we have green tests PTAL |
gabemontero
force-pushed
the
fix-invalid-label
branch
from
23e3aae
to
4e30adb
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
install readiness TO for e2e-aws-serial |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@gabemontero: All pull requests linked via external trackers have merged. Bugzilla bug 1777337 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.4 |
|
@adambkaplan: new pull request created: #77 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
… value
Turns out we need label validation in addition to the existing prune label's length logic in the apiserver, like we did on OCM via openshift/openshift-controller-manager#62
The original test scenario was from our CI cluster, which creates builds objs directly vs. instantiating them from the build config.
This change handles the instantiate from build config scneraio
@openshift/openshift-team-developer-experience