-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1777337: employ k8s label value validation when creating build pod build label… #72
Bug 1777337: employ k8s label value validation when creating build pod build label… #72
Conversation
@gabemontero: This pull request references Bugzilla bug 1777337, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @adambkaplan |
non-build related failures in e2e-aws /test e2e-aws |
/test e2e-aws |
bump @adambkaplan we have green tests PTAL |
23e3aae
to
4e30adb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
install readiness TO for e2e-aws-serial |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@gabemontero: All pull requests linked via external trackers have merged. Bugzilla bug 1777337 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-4.4 |
@adambkaplan: new pull request created: #77 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
… value
Turns out we need label validation in addition to the existing prune label's length logic in the apiserver, like we did on OCM via openshift/openshift-controller-manager#62
The original test scenario was from our CI cluster, which creates builds objs directly vs. instantiating them from the build config.
This change handles the instantiate from build config scneraio
@openshift/openshift-team-developer-experience