Bug 1785023: Increase pull secrets controller QPS to 100 #84
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
approved
pkg/cmd/controller/interfaces.go
Outdated
| @@ -99,7 +107,7 @@ func NewControllerContext( | |||
|
|
|||
| ClientBuilder: OpenshiftControllerClientBuilder{ | |||
| ControllerClientBuilder: controller.SAControllerClientBuilder{ | |||
| ClientConfig: rest.AnonymousClientConfig(clientConfig), | |||
| ClientConfig: rest.AnonymousClientConfig(kubeClientConfig), | |||
There was a problem hiding this comment.
@smarterclayton from what I can gather, this client config is used when the controllers call ctx.ClientBuilder.ClientOrDie(...). Every controller in OCM calls this.
My fear is that by using a higher QPS across all controllers, we can DoS the kube apiserver.
adambkaplan
force-pushed
the
fix-sa-pullsecrets-ratelimit
branch
2 times, most recently
from
02548c6
to
6bd9f1d
Compare
adambkaplan
changed the title
openshift-ci-robot
added
bugzilla/valid-bug
|
@adambkaplan: This pull request references Bugzilla bug 1765294, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@adambkaplan: This pull request references Bugzilla bug 1765294, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @smarterclayton |
|
Test to ensure we don't regress this timing: openshift/origin#24776 |
Increase the k8s client QPS limit to 100, 200 burst for the service account pull secrets controller. This ensures that pull secrets for the registry are created as quickly as the tokens are generated.
adambkaplan
force-pushed
the
fix-sa-pullsecrets-ratelimit
branch
from
6bd9f1d
to
197704d
Compare
adambkaplan
changed the title
|
@adambkaplan: This pull request references Bugzilla bug 1785023, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/retest Failed to acquire lease |
|
/test e2e-aws |
|
Tested, seems to resolve the flake /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@adambkaplan: Some pull requests linked via external trackers have merged: . The following pull requests linked via external trackers have not merged:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@adambkaplan we need a backport for 4.4. This is bleeding. |
|
/cherry-pick release-4.4 |
|
@sttts: new pull request created: #89 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.3 |
|
@adambkaplan: new pull request created: #91 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Increase the k8s client QPS limit to 100, 200 burst for the service account pull secrets controller. This ensures that pull secrets for the registry are created as quickly as the tokens are generated.