-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BZ 1573476 - Add missing boolean data type #10432
Conversation
@openshift/team-documentation PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few suggestions.
@@ -1,16 +1,24 @@ | |||
By default, SELinux does not allow writing from a pod to a remote {gluster} | |||
server. To enable writing to {gluster} volumes with SELinux on, run the | |||
server. To enable writing to {gluster} volumes with SELinux on, type the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run makes more sense in this context.
following on each node running GlusterFS: | ||
|
||
[source,bash] | ||
---- | ||
$ sudo setsebool -P virt_sandbox_use_fusefs on <1> | ||
$ sudo setsebool -P virt_use_fusefs on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the note tag.
---- | ||
<1> The `-P` option makes the bool persistent between reboots. | ||
<1> The `-P` option makes the bool persistent between reboots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/bool/boolean
|
||
[NOTE] | ||
==== | ||
If using Atomic Host instead of RHEL, the SELinux booleans are cleared upon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/using Atomic Host instead of RHEL/you use Atomic Host
maybe s/cleared upon version upgrades,/cleared when you upgrade Atomic Host.
[NOTE] | ||
==== | ||
If using Atomic Host instead of RHEL, the SELinux booleans are cleared upon | ||
version upgrades, forcing them to set them manually. Failing to set both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe s/forcing them to set them manually./When you upgrade Atomic Host, you must set these boolean values again.
LGTM |
https://bugzilla.redhat.com/show_bug.cgi?id=1573476