Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BZ 1573476 - Add missing boolean data type #10432

Merged
1 commit merged into from Jul 5, 2018
Merged

BZ 1573476 - Add missing boolean data type #10432

1 commit merged into from Jul 5, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jun 26, 2018

@ghost ghost added branch/enterprise-3.9 peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 26, 2018
@ghost ghost added this to the Next Release milestone Jun 26, 2018
@ghost ghost self-assigned this Jun 26, 2018
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 26, 2018
@ghost
Copy link
Author

ghost commented Jun 26, 2018

@openshift/team-documentation PTAL.

Copy link
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few suggestions.

@@ -1,16 +1,24 @@
By default, SELinux does not allow writing from a pod to a remote {gluster}
server. To enable writing to {gluster} volumes with SELinux on, run the
server. To enable writing to {gluster} volumes with SELinux on, type the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run makes more sense in this context.

following on each node running GlusterFS:

[source,bash]
----
$ sudo setsebool -P virt_sandbox_use_fusefs on <1>
$ sudo setsebool -P virt_use_fusefs on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the note tag.

----
<1> The `-P` option makes the bool persistent between reboots.
<1> The `-P` option makes the bool persistent between reboots.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/bool/boolean


[NOTE]
====
If using Atomic Host instead of RHEL, the SELinux booleans are cleared upon
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/using Atomic Host instead of RHEL/you use Atomic Host
maybe s/cleared upon version upgrades,/cleared when you upgrade Atomic Host.

[NOTE]
====
If using Atomic Host instead of RHEL, the SELinux booleans are cleared upon
version upgrades, forcing them to set them manually. Failing to set both
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe s/forcing them to set them manually./When you upgrade Atomic Host, you must set these boolean values again.

@kalexand-rh kalexand-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 26, 2018
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 29, 2018
@jhou1
Copy link
Member

jhou1 commented Jul 5, 2018

LGTM

@ghost ghost merged commit 16b3e31 into openshift:master Jul 5, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-3.9 branch/enterprise-3.10 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants