bug 1565363 fixing unschedulable parameter for upgrade #11628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
|
The manual upgrade section references ansible variables, we probably want to still tell them to remove those variables from their inventories but I'd add a step that tells them to label their masters, as far as I can tell the docs already tell them to mark them schedulable. |
sdodson
reviewed
Aug 17, 2018
upgrading/manual_upgrades.adoc
Outdated
| + | ||
| During upgrade, if a value is not provided for the `openshift_schedulable` | ||
| parameter, it is set to *true*. If a value is provided for | ||
| `openshift_schedulable`, it is not changed. |
There was a problem hiding this comment.
Since they're not running ansible during the manual upgrade I'd just omit this paragraph, you tell them to remove it from the inventory on 319 which accounts for any future ansible use. The oc adm manage-node <hostname> --schedulable=true will be the part that actually marks the node schedulable.
Otherwise lgtm
openshift-ci-robot
added
size/S
|
QE approved this PR in the source bug. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1565363
@jianlinliu, PTAL
@sdodson, FYI
Built version here: http://file.rdu.redhat.com/kalexand/081718/BZ1565363/upgrading/automated_upgrades.html