Trying to make documentation less Docker Centric #12302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should talk about Container Registries Container Images and Containers, rather then prefixing everything with Docker. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
openshift-ci-robot
added
the
size/XL
|
@vikram-redhat, thoughts? |
|
@rhatdan @kalexand-rh this requires sign-off from @mpbarrett and @aheslin at the very least. |
| @@ -90,7 +90,7 @@ Available diagnostics include: | |||
| |Check systemd service logs for problems. Does not require a configuration file to check against. | |||
|
|
|||
| |`ClusterRegistry` | |||
| |Check that the cluster has a working Docker registry for builds and image streams. | |||
| |Check that the cluster has a working container registry for builds and image streams. | |||
There was a problem hiding this comment.
We say "image registry" or "container image registry",, not "container registry" in product explanations.
|
This is the general direction. I'll add a few comments though about explicit naming. |
| @@ -11,7 +11,7 @@ toc::[] | |||
|
|
|||
| == Description | |||
| [%hardbreaks] | |||
| Image is an immutable representation of a Docker image and metadata at a point in time. | |||
| Image is an immutable representation of a container image and metadata at a point in time. | |||
There was a problem hiding this comment.
These are automatically generated and can't be changed like this (rest_api)
| @@ -133,7 +133,7 @@ issue. | |||
| header the new `*userAgentMatching*` configuration setting. | |||
|
|
|||
| [[ose-integrated-docker-registry]] | |||
| ==== Integrated Docker Registry | |||
| ==== Integrated Container Registries | |||
There was a problem hiding this comment.
Integrated Container Image Registry singular
|
I took @smarterclayton's suggestions, removed the changes to the rest_api topics, and made a new PR here: #12357 |
|
Per @vikram-redhat, I'm closing this PR and will merge #12357 and apply it to 3.11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should talk about
Container Registries
Container Images
and Containers, rather then prefixing everything with Docker.
Signed-off-by: Daniel J Walsh dwalsh@redhat.com