Specifying more than 3 nodes on Cluster Logging CR creates invalid Elasticsearch CR

[mburke5678]

https://bugzilla.redhat.com/show_bug.cgi?id=1706134

[anpingli]

The nodeCount can >3 now. The maximum Elasticsearch master nodes(pods) number is 3. That means: when the size >3, 3 elasticsearch nodes(pods) are created as Master-eligible node (using roles: master,client,data) , the other ES nodes(pods) will be created as Data only node ( using roles: client,data).
Refer to https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-node.html

For example: when nodeCount=4,

[anli@preserve-anli-slave 41]$oc get elasticsearch -o yaml
<---snip--->
nodes:
- genUUID: x6kdekli
  nodeCount: 1
  resources: {}
  roles:
  - client
  - data
  storage: {}
- genUUID: x6kdekli
  nodeCount: 3
  resources: {}
  roles:
  - client
  - data
  - master
  storage: {}
redundancyPolicy: ZeroRedundancy
<---snip--->

[anli@preserve-anli-slave 41]$ oc get deployment
cluster-logging-operator       1/1     1            1           18h
elasticsearch-cd-x6kdekli-1    0/1     1            0           6m54s
elasticsearch-cdm-x6kdekli-1   1/1     1            1           18h
elasticsearch-cdm-x6kdekli-2   0/1     1            0           6m49s
elasticsearch-cdm-x6kdekli-3   0/1     1            0           6m44s

[mburke5678]

@anpingli Thank you. I misread the BZ. How is this:

The maximum number of Elasticsearch master nodes is three. If you specify a nodeCount greater than 3, {product-title} creates three Elasticsearch nodes that are Master-eligible nodes, with the master, client, and data roles. The additional Elasticsearch nodes are created as Data only node, using client and data roles. Master nodes perform cluster-wide actions such as creating or deleting an index, shard allocation, and tracking nodes. Data nodes hold the shards and perform data-related operations such as CRUD, search, and aggregations. Data-related operations are I/O-, memory-, and CPU-intensive. It is important to monitor these resources and to add more Data nodes if the current nodes are overloaded.

[anpingli]

LGTM

[mburke5678]

/ok-to-test