Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1376585 Followup to 3916 #3919

Merged
merged 1 commit into from Mar 14, 2017
Merged

Bug 1376585 Followup to 3916 #3919

merged 1 commit into from Mar 14, 2017

Conversation

bfallonf
Copy link

As per #3916

Essentially moved the section to a different location, but also some minor rewording.

cc @sjenning @derekwaynecarr Let me know if there's any disagreements.

@ahardin-rh @adellape @bmcelvee @mburke5678 Peer review please?

@bfallonf
Copy link
Author

[rev_history]
|xref:../admin_guide/manage_nodes.adoc#admin-guide-manage-nodes[Managing Nodes]
|Added the xref:../admin_guide/manage_nodes.adoc#admin-guide-max-pods-per-node[Setting Maximum Pods Per Node] section.
%

@bfallonf bfallonf added this to the Next Release milestone Mar 13, 2017
adellape
adellape approved these changes Mar 13, 2017
View reviewed changes
Copy link
Contributor

@adellape adellape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could drop the ====s around the two code blocks since we don't use those anymore, but otherwise LGTM!

@mburke5678
Copy link
Contributor

LGTM

@bfallonf bfallonf changed the title Followup to 3916 Bug 1376585 Followup to 3916 Mar 14, 2017
@bfallonf
Copy link
Author

Also, as per this: https://bugzilla.redhat.com/show_bug.cgi?id=1376585

@bfallonf
Copy link
Author

And thanks all, I'll merge.

@bfallonf bfallonf merged commit 5578b96 into openshift:master Mar 14, 2017
@bfallonf bfallonf deleted the followup_3916 branch March 14, 2017 01:11
@bfallonf bfallonf mentioned this pull request Mar 16, 2017
Merged
@ahardin-rh ahardin-rh modified the milestones: Next Release, Staging, Published 03/20/2017 Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adellape adellape adellape approved these changes

Assignees
No one assigned
Labels
branch/enterprise-3.3 branch/enterprise-3.4
Projects
None yet
Milestone
Published 03/20/2017
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bfallonf @mburke5678 @adellape @ahardin-rh