Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNV-14816: workload updates are no longer tech preview #40787

Merged
merged 1 commit into from Feb 2, 2022
Merged

CNV-14816: workload updates are no longer tech preview #40787

merged 1 commit into from Feb 2, 2022

Conversation

ousleyp
Copy link
Member

@ousleyp ousleyp commented Jan 19, 2022 •
edited

@ousleyp ousleyp added CNV Label for all CNV PRs branch/enterprise-4.10 labels Jan 19, 2022
@ousleyp ousleyp added this to the Future Release milestone Jan 19, 2022
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 19, 2022
@netlify
Copy link

netlify bot commented Jan 19, 2022 •
edited

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 07305bb

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61faebc770352400078a281e

😎 Browse the preview: https://deploy-preview-40787--osdocs.netlify.app

@ousleyp
Copy link
Member Author

ousleyp commented Feb 1, 2022

@davidvossel Hi David, I recently added a section about timeouts to modules/virt-about-workload-updates.adoc. Could you please take a look to make sure it looks accurate?

Direct preview build link

Thanks!

@ousleyp ousleyp force-pushed the updates-4-10 branch 2 times, most recently from 565e938 to f7ac6e6 Compare February 1, 2022 02:16
tiraboschi
tiraboschi approved these changes Feb 1, 2022
View reviewed changes
modules/virt-about-workload-updates.adoc

*** Virtual machine instances (VMIs) that support live migration are migrated during the upgrade process.
* VMIs that do not support live migration use the `Evict` update strategy. If a VMI is controlled by a `VirtualMachine` object that has a `runStrategy` value of `always`, a new VMI is created in a new pod with updated components.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidvossel please keep me honest on this: with LiveMigrate and Evict, a VM configured with live migration is never going to be evicted even if the VMI continuously fails to be migrated for any reason. Right?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

under normal operation, a VMI set with EvictionStrategy: LiveMigrate will not shutdown during eviction for any reason. The VMI will either be live migrated, or in the event that live migration isn't possible the VMI will block the eviction indefinitely.

@dbasunag
Copy link

dbasunag commented Feb 1, 2022

lgtm

sjhala-ccs
sjhala-ccs reviewed Feb 2, 2022
View reviewed changes
Copy link
Contributor

@sjhala-ccs sjhala-ccs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of questions, otherwise LGTM.

modules/virt-about-workload-updates.adoc Outdated Show resolved Hide resolved
modules/virt-about-workload-updates.adoc Outdated Show resolved Hide resolved
modules/virt-about-workload-updates.adoc Outdated Show resolved Hide resolved
@sjhala-ccs sjhala-ccs added the peer-review-done Signifies that the peer review team has reviewed this PR label Feb 2, 2022
@davidvossel
Copy link

@davidvossel Hi David, I recently added a section about timeouts to modules/virt-about-workload-updates.adoc. Could you please take a look to make sure it looks accurate?

yes I reviewed the doc. Your section on timeouts is very accurate, thanks!

@ousleyp ousleyp merged commit e1218d6 into openshift:main Feb 2, 2022
@ousleyp
Copy link
Member Author

ousleyp commented Feb 2, 2022

/cherrypick enterprise-4.10

@openshift-cherrypick-robot
Copy link

@ousleyp: #40787 failed to apply on top of branch "enterprise-4.10":

Applying: CNV-14816: workload updates are no longer tech preview
Using index info to reconstruct a base tree...
M	_topic_maps/_topic_map.yml
M	virt/upgrading-virt.adoc
Falling back to patching base and 3-way merge...
Auto-merging virt/upgrading-virt.adoc
CONFLICT (content): Merge conflict in virt/upgrading-virt.adoc
Removing modules/virt-opting-out-workload-updates.adoc
Auto-merging _topic_maps/_topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 CNV-14816: workload updates are no longer tech preview
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ousleyp ousleyp mentioned this pull request Feb 2, 2022
Merged
@bobfuru bobfuru modified the milestones: Future Release, OCP 4.10 GA Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidvossel davidvossel davidvossel left review comments

@sjhala-ccs sjhala-ccs sjhala-ccs left review comments

@tiraboschi tiraboschi tiraboschi approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.10 CNV Label for all CNV PRs peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.10 GA
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ousleyp @dbasunag @davidvossel @openshift-cherrypick-robot @tiraboschi @sjhala-ccs @bobfuru