Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]: DNS mgt policy #50874

Closed
wants to merge 1 commit into from
Closed

[WIP]: DNS mgt policy #50874

wants to merge 1 commit into from

Conversation

Amrita42
Copy link
Contributor

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 26, 2022
@Amrita42 Amrita42 changed the title DNS mgt policy [WIP]: DNS mgt policy Sep 26, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2022
@ocpdocs-previewbot
Copy link

🤖 Bots are busy building the preview. It will be available soon at:
https://50874--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/808

@GroceryBoyJr
Copy link
Contributor

@Amrita42 Here's an updated preview link - paste into comment 0 if you wish:
https://50874--docspreview.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-12-release-notes.html

GroceryBoyJr
GroceryBoyJr reviewed Sep 26, 2022
View reviewed changes
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 26, 2022
@GroceryBoyJr
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Sep 26, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 26, 2022

@GroceryBoyJr: The label(s) /label enterprise-4.12 cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, multi-arch, oadp, peer-review-done, peer-review-in-progress, peer-review-needed, rhacs, serverless, service-mesh, staff-eng-approved, telco

In response to this:

/label enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@GroceryBoyJr
Copy link
Contributor

Hey @Amrita42 LGTM. Can you get QE LGTM and please resubmit for merge review?

@GroceryBoyJr
Copy link
Contributor

/remove-label peer-review-needed
/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Sep 26, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2022
@openshift-merge-robot
Copy link

@Amrita42: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Amrita42
Copy link
Contributor Author

Amrita42 commented Oct 3, 2022

Thanks @GroceryBoyJr will do.

@Amrita42
Copy link
Contributor Author

Amrita42 commented Oct 3, 2022 •
edited

Closing this PR , dues to merge conflicts. New PR #51111.

@Amrita42 Amrita42 closed this Oct 3, 2022
@Amrita42 Amrita42 deleted the CFE-526-Config-dns-rel branch October 10, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GroceryBoyJr GroceryBoyJr GroceryBoyJr left review comments

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Amrita42 @ocpdocs-previewbot @GroceryBoyJr @openshift-merge-robot