Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds manual DNS config to 4.12 rel notes #51111

Closed
wants to merge 1 commit into from
Closed

adds manual DNS config to 4.12 rel notes #51111

wants to merge 1 commit into from

Conversation

Amrita42
Copy link
Contributor

@Amrita42 Amrita42 commented Oct 3, 2022 •
edited

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 3, 2022
@Amrita42 Amrita42 mentioned this pull request Oct 3, 2022
Closed
@Amrita42
Copy link
Contributor Author

Amrita42 commented Oct 3, 2022

/label peer-review-done

@openshift-ci openshift-ci bot added the peer-review-done Signifies that the peer review team has reviewed this PR label Oct 3, 2022
@ocpdocs-previewbot
Copy link

🤖 Bots are busy building the preview. It will be available soon at:
https://51111--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/1145

@Amrita42 Amrita42 changed the title adds manual DNS config adds manual DNS config to 4.12 rel notes Oct 3, 2022
@thejasn
Copy link

thejasn commented Oct 3, 2022

LGTM
Awaiting docs PR to merge for lgtm label

@Amrita42 Amrita42 force-pushed the CFE-526-Config-dns-rel-new branch 2 times, most recently from 58eadab to d9e2dc6 Compare October 4, 2022 06:40
@Amrita42
Copy link
Contributor Author

Amrita42 commented Oct 4, 2022

@thejasn the doc PR is now merged fyi.

@thejasn
Copy link

thejasn commented Oct 4, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2022
@Amrita42
Copy link
Contributor Author

Amrita42 commented Oct 4, 2022

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 4, 2022
kalexand-rh
kalexand-rh reviewed Oct 4, 2022
View reviewed changes
Copy link
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been approved by QE?

release_notes/ocp-4-12-release-notes.adoc Outdated
[id="ocp-4-12-nw-configure-dns-management"]
==== Configuration of an Ingress Controller for manual DNS management

You can now configure an Ingress Controller to stop automatic DNS management and start manual DNS management. Set `dnsManagementPolicy` to specify when it should be automatically or manually managed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

! should verb
Whenever possible, rewrite in a more direct way. Do not use "should" to refer to an action that must be performed.

Generally, when you specify the name of a command, parameter, or option in text, specify the word command, parameter, or option after the name.
Command, parameter, and option names are not translated; without the identifying noun, users might be confused about what the name represents.

Copy link
Contributor Author

@Amrita42 Amrita42 Oct 6, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kalexand-rh The main feature/doc PR has been approved by QE , the same addition to the rel notes, is QE ack required (Dev ack is there)?

@kalexand-rh kalexand-rh removed the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 4, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2022

New changes are detected. LGTM label has been removed.

@Amrita42
Copy link
Contributor Author

Closing this PR due to merge conflicts , created a new PR taking fwd all feedback >> #51417

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 10, 2022
@openshift-merge-robot
Copy link

@Amrita42: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Amrita42 Amrita42 closed this Oct 10, 2022
@ShudiLi
Copy link
Member

ShudiLi commented Oct 11, 2022

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 11, 2022
@Amrita42 Amrita42 deleted the CFE-526-Config-dns-rel-new branch November 9, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalexand-rh kalexand-rh kalexand-rh left review comments

Assignees

@thejasn thejasn

Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Amrita42 @ocpdocs-previewbot @thejasn @openshift-merge-robot @ShudiLi @kalexand-rh