Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds the new ratio of user defined vs OCP tags #50969

Merged
merged 1 commit into from
Oct 10, 2022
Merged

adds the new ratio of user defined vs OCP tags #50969

merged 1 commit into from
Oct 10, 2022

Conversation

Amrita42
Copy link
Contributor

@Amrita42 Amrita42 commented Sep 28, 2022 •
edited
Loading

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 28, 2022
@ocpdocs-previewbot
Copy link

🤖 Bots are busy building the preview. It will be available soon at:
https://50969--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/932

@TrilokGeer
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2022
@Amrita42
Copy link
Contributor Author

Amrita42 commented Oct 4, 2022

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 4, 2022
@nalhadef
Copy link
Contributor

nalhadef commented Oct 4, 2022

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Oct 4, 2022
@nalhadef
Copy link
Contributor

nalhadef commented Oct 4, 2022

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 4, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2022

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2022
@Amrita42
Copy link
Contributor Author

Amrita42 commented Oct 6, 2022

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 6, 2022
@aireilly
Copy link
Contributor

aireilly commented Oct 6, 2022

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Oct 6, 2022
aireilly
aireilly reviewed Oct 6, 2022
View reviewed changes
Copy link
Contributor

@aireilly aireilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. However, I'm concerned that this table is not very useable at all on the docs.openshift site build. The scroll bar is at the bottom of the table making it very difficult to read because you have to scroll up and down and left and right.

@aireilly
Copy link
Contributor

aireilly commented Oct 6, 2022

/label peer-review-done

@nalhadef
Copy link
Contributor

nalhadef commented Oct 6, 2022

LGTM, @Amrita42!

@yunjiang29
Copy link
Contributor

lgtm.

@Amrita42
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 10, 2022
@lpettyjo lpettyjo added branch/enterprise-4.12 and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 10, 2022
@lpettyjo lpettyjo added this to the Planned for 4.12 GA milestone Oct 10, 2022
@lpettyjo lpettyjo merged commit ad946d6 into openshift:main Oct 10, 2022
@lpettyjo
Copy link
Contributor

/cherrypick enterprise-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 10, 2022
Merged
@openshift-cherrypick-robot
Copy link

@lpettyjo: new pull request created: #51427

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh kalexand-rh removed the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 12, 2022
@Amrita42 Amrita42 deleted the CFE-592 branch December 7, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aireilly aireilly aireilly left review comments

@nalhadef nalhadef nalhadef left review comments

@TrilokGeer TrilokGeer TrilokGeer left review comments

Assignees

@TrilokGeer TrilokGeer

Labels
branch/enterprise-4.12 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.12 GA
Development

Successfully merging this pull request may close these issues.
9 participants
@Amrita42 @ocpdocs-previewbot @TrilokGeer @nalhadef @aireilly @yunjiang29 @lpettyjo @openshift-cherrypick-robot @kalexand-rh