Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MULTIARCH-3176] Add deprecation note to IBM Z installation #53985

Merged
merged 1 commit into from
Dec 22, 2022
Merged

[MULTIARCH-3176] Add deprecation note to IBM Z installation #53985

merged 1 commit into from
Dec 22, 2022

Conversation

SNiemann15
Copy link
Contributor

@SNiemann15 SNiemann15 commented Dec 19, 2022 •
edited

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 19, 2022
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Dec 19, 2022 •
edited

🤖 Updated build preview is available at:
https://53985--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/5845

@SNiemann15 SNiemann15 changed the title add deprecation note to ibm z install [MULTIARCH-3176] Add deprecation note to IBM Z installation Dec 19, 2022
@SNiemann15 SNiemann15 force-pushed the ibmz_install_412 branch 2 times, most recently from af9165b to a8d680c Compare December 20, 2022 13:36
@holgwolf
Copy link

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Dec 21, 2022

@holgwolf: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SNiemann15
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 21, 2022
mburke5678
mburke5678 reviewed Dec 21, 2022
View reviewed changes
modules/installation-requirements-user-infra-ibm-z-kvm.adoc Outdated

[NOTE]
====
Support for {op-system} functionality for IBM z13 all models, LinuxONE Emperor, and LinuxONE Rockhopper is deprecated. While these hardware models remain fully supported in {product-title} 4.12, Red Hat recommends that you use later hardware models.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IBM Style Guide recommends not using while to mean although or though, as in this context.
Maybe:
Even thought these hardware models...
_These hardware models remain fully supported in {product-title} 4.12. However, Red Hat recommends...

mburke5678
mburke5678 reviewed Dec 21, 2022
View reviewed changes
modules/minimum-ibm-z-system-requirements.adoc Outdated

[NOTE]
====
Support for {op-system} functionality for IBM z13 all models, LinuxONE Emperor, and LinuxONE Rockhopper is deprecated. While these hardware models remain fully supported in {product-title} 4.12, Red Hat recommends that you use later hardware models.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here with While.

@mburke5678
Copy link
Contributor

@SNiemann15 A couple of nits. Otherwise LGTM

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.12 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 21, 2022
@mburke5678 mburke5678 added this to the Continuous Release milestone Dec 21, 2022
@SNiemann15
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Dec 22, 2022
@gaurav-nelson gaurav-nelson merged commit 6038092 into openshift:main Dec 22, 2022
@gaurav-nelson
Copy link
Contributor

/cherrypick enterprise-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 22, 2022
Merged
@openshift-cherrypick-robot
Copy link

@gaurav-nelson: new pull request created: #54105

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SNiemann15 SNiemann15 deleted the ibmz_install_412 branch December 22, 2022 12:39
@alishaIBM alishaIBM mentioned this pull request Jan 9, 2023
Merged
@kalexand-rh kalexand-rh removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mburke5678 mburke5678 mburke5678 left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.12 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.12 GA
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@SNiemann15 @ocpdocs-previewbot @holgwolf @mburke5678 @gaurav-nelson @openshift-cherrypick-robot @kalexand-rh