Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.12 install doc updates from IBM P #54260

Merged
merged 1 commit into from
Jan 6, 2023
Merged

4.12 install doc updates from IBM P #54260

merged 1 commit into from
Jan 6, 2023

Conversation

alishaIBM
Copy link
Contributor

@alishaIBM alishaIBM commented Jan 5, 2023 •
edited

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 5, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 5, 2023 •
edited

🤖 Updated build preview is available at:
https://54260--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/6360

@alishaIBM
Copy link
Contributor Author

/assign @manojnkumar

@manojnkumar
Copy link

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2023
@alishaIBM
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 5, 2023
@tmalove
Copy link
Contributor

tmalove commented Jan 5, 2023

/remove-label peer-review-needed
/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 5, 2023
tmalove
tmalove reviewed Jan 5, 2023
View reviewed changes
Copy link
Contributor

@tmalove tmalove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alishaIBM Just checking to make sure that you meant that the 'IBM Power 9' models are deprecated because you removed 'IBM Power 8' from the content Otherwise looks fine.

@tmalove
Copy link
Contributor

tmalove commented Jan 5, 2023

/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 5, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2023
@manojnkumar
Copy link

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2023
@alishaIBM
Copy link
Contributor Author

alishaIBM commented Jan 6, 2023 •
edited

@alishaIBM Just checking to make sure that you meant that the 'IBM Power 9' models are deprecated because you removed 'IBM Power 8' from the content Otherwise looks fine.

@tmalove Thanks for pointing out. Have updated the PR.

@alishaIBM
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 6, 2023
@stevsmit stevsmit added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.12 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jan 6, 2023
@stevsmit stevsmit added this to the Planned for 4.12 GA milestone Jan 6, 2023
@stevsmit stevsmit removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jan 6, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 6, 2023

New changes are detected. LGTM label has been removed.

@stevsmit stevsmit added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2023
@stevsmit stevsmit merged commit ad060ba into openshift:main Jan 6, 2023
@stevsmit
Copy link
Member

stevsmit commented Jan 6, 2023

/cherry-pick enterprise-4.12

@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #54318

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevsmit stevsmit stevsmit left review comments

@tmalove tmalove tmalove left review comments

Assignees

@manojnkumar manojnkumar

Labels
branch/enterprise-4.12 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.12 GA
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@alishaIBM @ocpdocs-previewbot @manojnkumar @tmalove @stevsmit @openshift-cherrypick-robot