Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDOCS-3791:Disable default SC #55377

Merged
merged 1 commit into from
Apr 21, 2023
Merged

OSDOCS-3791:Disable default SC #55377

merged 1 commit into from
Apr 21, 2023

Conversation

lpettyjo
Copy link
Contributor

@lpettyjo lpettyjo commented Jan 31, 2023 •
edited

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 31, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 31, 2023 •
edited by openshift-ci bot

@lpettyjo: This pull request references OSDOCS-3791 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lpettyjo lpettyjo added this to the Planned for 4.13 GA milestone Jan 31, 2023
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 31, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 31, 2023 •
edited by openshift-ci bot

@lpettyjo: This pull request references OSDOCS-3791 which is a valid jira issue.

In response to this:

Version(s): 4.13+

Issue:https://issues.redhat.com/browse/OSDOCS-3791

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 31, 2023 •
edited by openshift-ci bot

@lpettyjo: This pull request references OSDOCS-3791 which is a valid jira issue.

In response to this:

Version(s): 4.13+

Issue:https://issues.redhat.com/browse/OSDOCS-3791

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

PTAL: @dobsonj, @ropatil010, @gcharot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 31, 2023 •
edited

🤖 Updated build preview is available at:
https://55377--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/14521

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 31, 2023 •
edited by openshift-ci bot

@lpettyjo: This pull request references OSDOCS-3791 which is a valid jira issue.

In response to this:

Version(s): 4.13+

Issue:https://issues.redhat.com/browse/OSDOCS-3791

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

PTAL: @dobsonj, @ropatil010, @gcharot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 31, 2023 •
edited by openshift-ci bot

@lpettyjo: This pull request references OSDOCS-3791 which is a valid jira issue.

In response to this:

Version(s): 4.13+

Issue:https://issues.redhat.com/browse/OSDOCS-3791

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

PTAL: @dobsonj, @ropatil010, @gcharot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lpettyjo lpettyjo added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 31, 2023
@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jan 31, 2023
@mburke5678
Copy link
Contributor

@lpettyjo A few nits. Otherwise LGTM

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 31, 2023
@lpettyjo lpettyjo added peer-review-needed Signifies that the peer review team needs to review this PR and removed peer-review-done Signifies that the peer review team has reviewed this PR labels Feb 3, 2023
@lpettyjo
Copy link
Contributor Author

lpettyjo commented Feb 3, 2023

Had substantial re-write, so requesting 2nd peer review.

@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 3, 2023
@mburke5678 mburke5678 added the peer-review-done Signifies that the peer review team has reviewed this PR label Feb 3, 2023
@lpettyjo lpettyjo force-pushed the OSDOCS-3791 branch 2 times, most recently from 91486f2 to ff8cdfc Compare February 6, 2023 15:32
@lpettyjo lpettyjo mentioned this pull request Feb 7, 2023
Merged
1 task
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 9, 2023 •
edited by openshift-ci bot

@lpettyjo: This pull request references OSDOCS-3791 which is a valid jira issue.

In response to this:

Version(s): 4.13+

Issue:https://issues.redhat.com/browse/OSDOCS-3791

Link to docs preview: https://55377--docspreview.netlify.app/openshift-enterprise/latest/storage/container_storage_interface/persistent-storage-csi-sc-manage.html

QE review:

  • QE has approved this change.

Additional information:

PTAL: @dobsonj, @ropatil010, @gcharot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dobsonj
dobsonj reviewed Feb 14, 2023
View reviewed changes
Copy link
Member

@dobsonj dobsonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor question, but overall LGTM.

modules/persistent-storage-csi-sc-managing-cli.adoc Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 31, 2023
@lpettyjo lpettyjo force-pushed the OSDOCS-3791 branch 2 times, most recently from e28d572 to e617f1f Compare March 31, 2023 19:34
@ropatil010
Copy link

LGTM for "Managing the default storage class" part.
Thanks.

@lpettyjo lpettyjo force-pushed the OSDOCS-3791 branch 3 times, most recently from 2756fae to ebbd56a Compare April 5, 2023 18:12
@lpettyjo
Copy link
Contributor Author

@lpettyjo Need to add retro SC assignment module.

@gcharot
Copy link

gcharot commented Apr 17, 2023

LGTM thx

@lpettyjo lpettyjo force-pushed the OSDOCS-3791 branch 2 times, most recently from 3b6d0ef to 3dae81d Compare April 19, 2023 13:35
@gcharot
Copy link

gcharot commented Apr 20, 2023

last change LGTM thx

@dobsonj
Copy link
Member

dobsonj commented Apr 20, 2023

LGTM

@lpettyjo lpettyjo merged commit 185a10a into openshift:main Apr 21, 2023
1 check passed
@lpettyjo
Copy link
Contributor Author

/cherrypick enterprise-4.13

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 21, 2023
Merged
@openshift-cherrypick-robot
Copy link

@lpettyjo: new pull request created: #59119

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcharot gcharot gcharot left review comments

@dobsonj dobsonj dobsonj left review comments

@mburke5678 mburke5678 mburke5678 left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.13 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
4.13 GA
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@lpettyjo @openshift-ci-robot @ocpdocs-previewbot @mburke5678 @ropatil010 @gcharot @dobsonj @openshift-cherrypick-robot