Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSDOCS#5179:Retroactive default SC assignment #55649

Merged
merged 1 commit into from Apr 14, 2023

Conversation

lpettyjo
Copy link
Contributor

@lpettyjo lpettyjo commented Feb 7, 2023

Version(s):4.13+

Issue:https://issues.redhat.com/browse/OSDOCS-5179

Link to docs preview: No preview, since this is a module that will become part of the assembly in this other 4.13 PR #55377.

QE review:

  • QE has approved this change.

Additional information:

PTAL: @RomanBednar, @chao007, @gcharot

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 7, 2023

@lpettyjo: This pull request references OSDOCS-5179 which is a valid jira issue.

In response to this:

Version(s):4.13+

Issue:https://issues.redhat.com/browse/OSDOCS-5179

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 7, 2023
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 7, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 7, 2023

🤖 Updated build preview is available at:
https://55649--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/13510

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 7, 2023

@lpettyjo: This pull request references OSDOCS-5179 which is a valid jira issue.

In response to this:

Version(s):4.13+

Issue:https://issues.redhat.com/browse/OSDOCS-5179

Link to docs preview: No preview, since this is a module that will become part of the assembly in this other 4.13 PR #55377.

QE review:

  • QE has approved this change.

Additional information:

PTAL: @RomanBednar, @chao007, @gcharot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lpettyjo lpettyjo added peer-review-needed Signifies that the peer review team needs to review this PR branch/enterprise-4.13 labels Feb 7, 2023
@lpettyjo lpettyjo added this to the Planned for 4.13 GA milestone Feb 7, 2023
@lpettyjo lpettyjo changed the title OSDOCS-5179:Retroacitve default SC assignment OSDOCS-5179:Retroactive default SC assignment Feb 8, 2023
@abhatt-rh
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 8, 2023
Copy link
Contributor

@abhatt-rh abhatt-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lpettyjo, mostly LGTM!
I added a few minor suggestions for you consideration. Thank you!

Kindly add and update the preview after the module is added to the said assembly as noted in your comment 0.

modules/persistent-storage-csi-sc-multiple-none.adoc Outdated Show resolved Hide resolved
modules/persistent-storage-csi-sc-multiple-none.adoc Outdated Show resolved Hide resolved
modules/persistent-storage-csi-sc-multiple-none.adoc Outdated Show resolved Hide resolved
@abhatt-rh
Copy link
Contributor

Hi @lpettyjo
I'm adding the peer-review-done label, but just noting that since I see a couple of SME comments post submitting my review, which might result in content changes, feel free to request another peer review. Thanks!

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 8, 2023
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 10, 2023
@kalexand-rh kalexand-rh changed the title OSDOCS-5179:Retroactive default SC assignment OSDOCS#5179:Retroactive default SC assignment Feb 15, 2023
@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 15, 2023
@openshift-ci-robot
Copy link

@lpettyjo: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Version(s):4.13+

Issue:https://issues.redhat.com/browse/OSDOCS-5179

Link to docs preview: No preview, since this is a module that will become part of the assembly in this other 4.13 PR #55377.

QE review:

  • QE has approved this change.

Additional information:

PTAL: @RomanBednar, @chao007, @gcharot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RomanBednar
Copy link

@lpettyjo lgtm

@gcharot
Copy link

gcharot commented Apr 3, 2023

LGTM

@chao007
Copy link

chao007 commented Apr 6, 2023

LGTM

@lpettyjo lpettyjo merged commit a0bcf0e into openshift:main Apr 14, 2023
1 check passed
@lpettyjo
Copy link
Contributor Author

/cherrypick enterprise-4.13

@openshift-cherrypick-robot

@lpettyjo: new pull request created: #58728

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.13 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants