Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHDEVDOCS-5389: Correct the formatting of sample commands in Pipeline… #61415

Merged
merged 1 commit into from
Jun 21, 2023
Merged

RHDEVDOCS-5389: Correct the formatting of sample commands in Pipeline… #61415

merged 1 commit into from
Jun 21, 2023

Conversation

eromanova97
Copy link
Contributor

@eromanova97 eromanova97 commented Jun 19, 2023 •
edited
Loading

• Aligned team: Dev Tools
• OCP version for cherry-picking: enterprise-4.11 and later
• JIRA issue: RHDEVDOCS-5389
• Preview page: Using Pipelines as Code with a GitHub App
• SME Review: Not needed
• QE review: Not needed
• Peer-review: Completed by @Srivaralakshmi

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 19, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 19, 2023 •
edited by openshift-ci bot
Loading

@ekristova: This pull request references RHDEVDOCS-5389 which is a valid jira issue.

In response to this:

• Aligned team: Dev Tools
• OCP version for cherry-picking: enterprise-4.12 and later
• JIRA issue: RHDEVDOCS-5389
• Preview page:
• SME Review: Not needed
• QE review: Not needed
• Peer-review: @

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 19, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 19, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://61415--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/18343

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 20, 2023 •
edited by openshift-ci bot
Loading

@ekristova: This pull request references RHDEVDOCS-5389 which is a valid jira issue.

In response to this:

• Aligned team: Dev Tools
• OCP version for cherry-picking: enterprise-4.12 and later
• JIRA issue: RHDEVDOCS-5389
• Preview page: Using Pipelines as Code with a GitHub App
• SME Review: Not needed
• QE review: Not needed
• Peer-review: @

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 20, 2023 •
edited by openshift-ci bot
Loading

@ekristova: This pull request references RHDEVDOCS-5389 which is a valid jira issue.

In response to this:

• Aligned team: Dev Tools
• OCP version for cherry-picking: enterprise-4.11 and later
• JIRA issue: RHDEVDOCS-5389
• Preview page: Using Pipelines as Code with a GitHub App
• SME Review: Not needed
• QE review: Not needed
• Peer-review: @

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Srivaralakshmi
Srivaralakshmi requested changes Jun 20, 2023
View reviewed changes
Copy link
Member

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekristova PTAL at my query.

modules/op-using-pipelines-as-code-with-a-github-app.adoc Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 20, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 20, 2023 •
edited by openshift-ci bot
Loading

@ekristova: This pull request references RHDEVDOCS-5389 which is a valid jira issue.

In response to this:

• Aligned team: Dev Tools
• OCP version for cherry-picking: enterprise-4.11 and later
• JIRA issue: RHDEVDOCS-5389
• Preview page: Using Pipelines as Code with a GitHub App
• SME Review: Not needed
• QE review: Not needed
• Peer-review: Completed by @Srivaralakshmi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Srivaralakshmi
Srivaralakshmi approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekristova Thanks for the changes. Approved!

@Srivaralakshmi
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2023
@eromanova97 eromanova97 changed the title [WIP] RHDEVDOCS-5389: Correct the formatting of sample commands in Pipeline… RHDEVDOCS-5389: Correct the formatting of sample commands in Pipeline… Jun 21, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2023
@gabriel-rh gabriel-rh merged commit 23a27ad into openshift:main Jun 21, 2023
@gabriel-rh
Copy link
Contributor

/cherry-pick enterprise-4.14

@gabriel-rh
Copy link
Contributor

/cherry-pick enterprise-4.13

@gabriel-rh
Copy link
Contributor

/cherry-pick enterprise-4.12

@gabriel-rh
Copy link
Contributor

/cherry-pick enterprise-4.11

@openshift-cherrypick-robot
Copy link

@gabriel-rh: new pull request created: #61499

In response to this:

/cherry-pick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 21, 2023
Merged
@openshift-cherrypick-robot
Copy link

@gabriel-rh: new pull request created: #61500

In response to this:

/cherry-pick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Jun 21, 2023
Merged
Merged
@openshift-cherrypick-robot
Copy link

@gabriel-rh: new pull request created: #61501

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 21, 2023
Merged
@openshift-cherrypick-robot
Copy link

@gabriel-rh: new pull request created: #61502

In response to this:

/cherry-pick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Srivaralakshmi Srivaralakshmi Srivaralakshmi approved these changes

Assignees

@Srivaralakshmi Srivaralakshmi

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eromanova97 @openshift-ci-robot @ocpdocs-previewbot @Srivaralakshmi @gabriel-rh @openshift-cherrypick-robot