-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV#33978-1: ROSA support and general storage update #67365
Conversation
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/31830 |
/lgtm |
/label peer-review-in-progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/label peer-review-done |
lgtm in general, but I would like to comment about:
I think we can mention that at least the worker nodes should be bare metal instances (e.g. |
New changes are detected. LGTM label has been removed. |
Changed to:
|
/cherrypick enterprise-4.15 |
/cherrypick enterprise-4.14 |
@ousleyp: new pull request created: #67422 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ousleyp: new pull request created: #67423 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s): 4.14+
Issue: CNV-33978
Link to docs preview: https://67365--docspreview.netlify.app/openshift-enterprise/latest/virt/install/preparing-cluster-for-virt#virt-aws-bm_preparing-cluster-for-virt
QE review:
Additional information: