Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSDOCS#9302]: RN for OSASINFRA-3207 (Integrate CAPO into cluster-capi-operator (TP)) #70182

Merged
merged 1 commit into from Jan 15, 2024

Conversation

obrown1205
Copy link
Contributor

@obrown1205 obrown1205 commented Jan 12, 2024

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 12, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 12, 2024

🤖 Mon Jan 15 20:09:38 - Prow CI generated the docs preview: https://70182--ocpdocs-pr.netlify.app

@obrown1205 obrown1205 force-pushed the OSDOCS-9302 branch 7 times, most recently from 120da08 to d7a0aa9 Compare January 13, 2024 01:11
@mdbooth
Copy link

mdbooth commented Jan 15, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2024
@obrown1205
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 15, 2024
@jab-rh jab-rh added this to the Planned for 4.15 GA milestone Jan 15, 2024
Copy link
Contributor

@jab-rh jab-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@obrown1205, left a comment. We've always just called them Operators, but if that's different in this instance, feel free to disregard. Thanks!

release_notes/ocp-4-15-release-notes.adoc Outdated Show resolved Hide resolved
@jab-rh jab-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 15, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2024
Copy link

openshift-ci bot commented Jan 15, 2024

New changes are detected. LGTM label has been removed.

@obrown1205
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 15, 2024
Copy link

openshift-ci bot commented Jan 15, 2024

@obrown1205: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jab-rh jab-rh merged commit 7b54ac1 into openshift:enterprise-4.15 Jan 15, 2024
2 checks passed
@jab-rh jab-rh removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 15, 2024
@mjpytlak
Copy link
Contributor

mjpytlak commented Jan 16, 2024

@obrown1205 I was resolving a merge conflict when I noticed that this entry does not have a heading. Was there a specific reason why you did not add a heading or is this just an oversight?

I also noticed that you have a couple instances of "OpenShift" that should be {product-title}.

@obrown1205
Copy link
Contributor Author

@mjpytlak Shoot - good catch. I'll create a small PR now to address it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.15 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants