Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix terms in CAPI for OpenStack RNs #75024

Merged
merged 1 commit into from
May 2, 2024
Merged

fix terms in CAPI for OpenStack RNs #75024

merged 1 commit into from
May 2, 2024

Conversation

jeana-redhat
Copy link
Contributor

@jeana-redhat jeana-redhat commented Apr 23, 2024 •
edited

Version(s):
4.15

Issue:
Follows up on #70182 and #70813 for OSDOCS-9302

Link to docs preview:

QE review:
N/A

Additional information:

@jeana-redhat jeana-redhat added this to the Continuous Release milestone Apr 23, 2024
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 23, 2024
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 23, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 23, 2024 •
edited

🤖 Thu May 02 15:00:14 - Prow CI generated the docs preview:

https://75024--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-15-release-notes.html

@mdbooth
Copy link

mdbooth commented May 2, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2024
@jeana-redhat jeana-redhat added the peer-review-needed Signifies that the peer review team needs to review this PR label May 2, 2024
@dfitzmau
Copy link
Contributor

dfitzmau commented May 2, 2024

/remove-label peer-review-needed

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 2, 2024
@dfitzmau
Copy link
Contributor

dfitzmau commented May 2, 2024

Hi @jeana-redhat . Added some minor feedback inline. Nice work!

/remove-label peer-review-in-progress

/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 2, 2024
@dfitzmau
Copy link
Contributor

dfitzmau commented May 2, 2024

/remove-label peer-review-needed

@openshift-ci openshift-ci bot removed the peer-review-needed Signifies that the peer review team needs to review this PR label May 2, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 2, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 2, 2024

New changes are detected. LGTM label has been removed.

@jeana-redhat
Copy link
Contributor Author

Thanks, @dfitzmau! added an attribute and left the existing things as they are (out of scope for this change). Appreciate the review

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 2, 2024

@jeana-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jeana-redhat jeana-redhat merged commit 9787934 into openshift:enterprise-4.15 May 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrb nrb nrb left review comments

@dfitzmau dfitzmau dfitzmau left review comments

Assignees

@mdbooth mdbooth

Labels
branch/enterprise-4.15 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jeana-redhat @ocpdocs-previewbot @mdbooth @dfitzmau @nrb