Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugzilla 1316593: Adding information to Reclaiming Resources section #7179

Merged
1 commit merged into from Feb 13, 2018
Merged

Bugzilla 1316593: Adding information to Reclaiming Resources section #7179

1 commit merged into from Feb 13, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jan 16, 2018 •
edited by ghost
Loading

@openshift/team-documentation PTAL.

https://bugzilla.redhat.com/show_bug.cgi?id=1316593

@ghost ghost added this to the Next Release milestone Jan 16, 2018
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 16, 2018
ahardin-rh
ahardin-rh reviewed Jan 16, 2018
View reviewed changes
install_config/persistent_storage/persistent_storage_nfs.adoc Outdated
====
A PV with retention policy of `Recycle` will scrub (`rm -rf`) the data and
mark it as `Available` for claim. The `Recycle` retention policy is deprecated in
future versions and should be avoided.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on what is meant by "future versions"? I see you have this PR labeled for 3.1 and later, so we should probably clarify. Other than that, LGTM!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About from which version volume recycler is deprecated: https://github.com/openshift/openshift-docs/blob/master/release_notes/ocp_3_6_release_notes.adoc

@ahardin-rh ahardin-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Jan 16, 2018
@ghost
Copy link
Author

ghost commented Jan 23, 2018 •
edited by ghost
Loading

[rev_history]
|xref:../install_config/persistent_storage/persistent_storage_nfs.adoc#install-config-persistent-storage-persistent-storage-nfs[Configuring Persistent Storage -> Using NFS]
|Updated the configuration examples in the xref:../install_config/persistent_storage/persistent_storage_nfs.adoc#nfs-reclaiming-resources[Reclaiming Resources] section.
%

@ghost ghost self-assigned this Jan 23, 2018
qinpingli
qinpingli reviewed Feb 6, 2018
View reviewed changes
install_config/persistent_storage/persistent_storage_nfs.adoc Outdated
*Recycle* are scrubbed (i.e., `rm -rf` is run on the volume) after being
released from their claim (i.e, after the user's `*PersistentVolumeClaim*` bound
to the volume is deleted). Once recycled, the NFS volume can be bound to a new
claim.

Once claim to a PV is released (that is, the is PVC deleted), the PV object
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/the is PVC deleted/the PVC is deleted/

@ghost
Copy link
Author

ghost commented Feb 7, 2018

@qinpingli Changes made, PTAL.

@qinpingli
Copy link

LGTM

@ghost ghost merged commit fee7a00 into openshift:master Feb 13, 2018
@ghost
Copy link
Author

ghost commented Feb 13, 2018

/cherrypick enterprise-3.1

@openshift-cherrypick-robot
Copy link

@tmorriso-rh: #7179 failed to apply on top of branch "enterprise-3.1":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	install_config/persistent_storage/persistent_storage_nfs.adoc
Falling back to patching base and 3-way merge...
Auto-merging install_config/persistent_storage/persistent_storage_nfs.adoc
CONFLICT (content): Merge conflict in install_config/persistent_storage/persistent_storage_nfs.adoc
Patch failed at 0001 Adding information to Reclaiming Resources section

In response to this:

/cherrypick enterprise-3.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ghost ghost mentioned this pull request Feb 13, 2018
Merged
@ghost
Copy link
Author

ghost commented Feb 13, 2018

/cherrypick enterprise-3.2

@openshift-cherrypick-robot
Copy link

@tmorriso-rh: #7179 failed to apply on top of branch "enterprise-3.2":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	install_config/persistent_storage/persistent_storage_nfs.adoc
Falling back to patching base and 3-way merge...
Auto-merging install_config/persistent_storage/persistent_storage_nfs.adoc
CONFLICT (content): Merge conflict in install_config/persistent_storage/persistent_storage_nfs.adoc
Patch failed at 0001 Adding information to Reclaiming Resources section

In response to this:

/cherrypick enterprise-3.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ghost ghost mentioned this pull request Feb 13, 2018
Merged
@ghost
Copy link
Author

ghost commented Feb 13, 2018

/cherrypick enterprise-3.5-stage

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 13, 2018
Merged
@openshift-cherrypick-robot
Copy link

@tmorriso-rh: new pull request created: #7756

In response to this:

/cherrypick enterprise-3.5-stage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ghost
Copy link
Author

ghost commented Feb 13, 2018

/cherrypick enterprise-3.6-stage

@openshift-cherrypick-robot
Copy link

@tmorriso-rh: new pull request created: #7757

In response to this:

/cherrypick enterprise-3.6-stage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 13, 2018
Merged
@ghost
Copy link
Author

ghost commented Feb 13, 2018

/cherrypick enterprise-3.7-stage

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 13, 2018
Merged
@openshift-cherrypick-robot
Copy link

@tmorriso-rh: new pull request created: #7758

In response to this:

/cherrypick enterprise-3.7-stage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ghost
Copy link
Author

ghost commented Feb 13, 2018

/cherrypick enterprise-3.9-stage

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 13, 2018
Merged
@openshift-cherrypick-robot
Copy link

@tmorriso-rh: new pull request created: #7759

In response to this:

/cherrypick enterprise-3.9-stage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Feb 13, 2018
Merged
Merged
@ghost ghost deleted the Bugzilla-1316593 branch February 13, 2018 17:14
@vikram-redhat vikram-redhat modified the milestones: Next Release, Staging, Published - 02/16/2018 Feb 16, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
branch/enterprise-3.1 branch/enterprise-3.2 branch/enterprise-3.3 branch/enterprise-3.4 branch/enterprise-3.5 branch/enterprise-3.6 branch/enterprise-3.7 branch/enterprise-3.9 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Published - 02/16/2018
Development

Successfully merging this pull request may close these issues.
5 participants
@qinpingli @openshift-cherrypick-robot @ahardin-rh @vikram-redhat @openshift-ci-robot