Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-25163: update disruptionless MCO behavior #72185

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

jldohmann
Copy link
Contributor

@jldohmann jldohmann commented Feb 27, 2024

@jldohmann jldohmann added this to the Continuous Release milestone Feb 27, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 27, 2024
@openshift-ci-robot
Copy link

@jldohmann: This pull request references Jira Issue OCPBUGS-25163, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s): 4.14+

Issue: https://issues.redhat.com/browse/OCPBUGS-25163

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 27, 2024
@jldohmann
Copy link
Contributor Author

/retest

@ocpdocs-previewbot
Copy link

🤖 Tue Feb 27 22:43:41 - Prow CI generated the docs preview:
https://72185--ocpdocs-pr.netlify.app

Copy link

openshift-ci bot commented Feb 27, 2024

@jldohmann: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jldohmann jldohmann added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 28, 2024
@jldohmann
Copy link
Contributor Author

@rioliu-rh could you PTAL for QE ack? This PR updates text to reflect MCO new behavior about cert management for user-provided CA updates

@GroceryBoyJr
Copy link
Contributor

/label peer-review-in-progress
/remove-label peer-review-needed
/assign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 28, 2024
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GroceryBoyJr
Copy link
Contributor

/remove-label peer-review-in-progress
/label peer-review-done
/unassign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 28, 2024
@rioliu-rh
Copy link

LGTM
/cc @sergiordlr @cdoern

@sergiordlr
Copy link

LGTM

@openshift-ci-robot
Copy link

@jldohmann: This pull request references Jira Issue OCPBUGS-25163, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Version(s): 4.14+

Issue: https://issues.redhat.com/browse/OCPBUGS-25163

Link to docs preview: https://72185--ocpdocs-pr.netlify.app/openshift-enterprise/latest/security/certificate_types_descriptions/proxy-certificates#customization

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jldohmann jldohmann merged commit 0297eb8 into openshift:main Feb 29, 2024
2 checks passed
@openshift-ci-robot
Copy link

@jldohmann: Jira Issue OCPBUGS-25163 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

Version(s): 4.14+

Issue: https://issues.redhat.com/browse/OCPBUGS-25163

Link to docs preview: https://72185--ocpdocs-pr.netlify.app/openshift-enterprise/latest/security/certificate_types_descriptions/proxy-certificates#customization

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jldohmann
Copy link
Contributor Author

/cherrypick enterprise-4.16

@jldohmann
Copy link
Contributor Author

/cherrypick enterprise-4.15

@jldohmann
Copy link
Contributor Author

/cherrypick enterprise-4.14

@openshift-cherrypick-robot

@jldohmann: new pull request created: #72394

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@jldohmann: new pull request created: #72395

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@jldohmann: new pull request created: #72396

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants