Skip to content

[enterprise-4.13] OCPBUGS-19453: add admonition about node reboot#73711

Merged
jldohmann merged 1 commit intoopenshift:enterprise-4.13from
jldohmann:OCPBUGS-19453
Mar 27, 2024
Merged

[enterprise-4.13] OCPBUGS-19453: add admonition about node reboot#73711
jldohmann merged 1 commit intoopenshift:enterprise-4.13from
jldohmann:OCPBUGS-19453

Conversation

@jldohmann
Copy link
Copy Markdown
Contributor

@jldohmann jldohmann commented Mar 25, 2024 •
edited
Loading

@jldohmann jldohmann added this to the Continuous Release milestone Mar 25, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 25, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 25, 2024

@jldohmann: This pull request references Jira Issue OCPBUGS-19453, which is invalid:

  • expected Jira Issue OCPBUGS-19453 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Version(s): 4.12, 4.13

Issue: https://issues.redhat.com/browse/OCPBUGS-19453

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 25, 2024
@jldohmann
Copy link
Copy Markdown
Contributor Author

jldohmann commented Mar 25, 2024

@sergiordlr could you PTAL for QE ack? this is related to #72185, but for pre-OCP 4.14 behavior where the node drains and reboots after updating certs. this PR adds a small note before the procedure about this

@ocpdocs-previewbot
Copy link
Copy Markdown

ocpdocs-previewbot commented Mar 25, 2024 •
edited
Loading

🤖 Mon Mar 25 20:32:11 - Prow CI generated the docs preview:
https://73711--ocpdocs-pr.netlify.app

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 25, 2024

@jldohmann: This pull request references Jira Issue OCPBUGS-19453, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
  • expected Jira Issue OCPBUGS-19453 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Version(s): 4.12, 4.13

Issue: https://issues.redhat.com/browse/OCPBUGS-19453

Link to docs preview: https://73711--ocpdocs-pr.netlify.app/openshift-enterprise/latest/security/certificates/replacing-default-ingress-certificate#replacing-default-ingress_replacing-default-ingress

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jldohmann jldohmann added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 25, 2024
@bergerhoffer
Copy link
Copy Markdown
Contributor

bergerhoffer commented Mar 25, 2024

/label peer-review-in-progress

@openshift-ci openshift-ci Bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 25, 2024
bergerhoffer
bergerhoffer reviewed Mar 25, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion!

Comment thread modules/customize-certificates-replace-default-router.adoc Outdated
@bergerhoffer
Copy link
Copy Markdown
Contributor

bergerhoffer commented Mar 25, 2024

/label peer-review-done
/remove-label peer-review-needed
/remove-label peer-review-in-progress

@openshift-ci openshift-ci Bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 25, 2024
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 25, 2024

@jldohmann: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rioliu-rh
Copy link
Copy Markdown

rioliu-rh commented Mar 27, 2024

LGTM

@jldohmann jldohmann merged commit 66bf947 into openshift:enterprise-4.13 Mar 27, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 27, 2024

@jldohmann: Jira Issue OCPBUGS-19453 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

Details

In response to this:

Version(s): 4.12, 4.13

Issue: https://issues.redhat.com/browse/OCPBUGS-19453

Link to docs preview: https://73711--ocpdocs-pr.netlify.app/openshift-enterprise/latest/security/certificates/replacing-default-ingress-certificate#replacing-default-ingress_replacing-default-ingress

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jldohmann
Copy link
Copy Markdown
Contributor Author

jldohmann commented Mar 27, 2024

/cherrypick enterprise-4.12

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Mar 27, 2024

@jldohmann: new pull request created: #73833

Details

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 27, 2024
Merged
@jldohmann jldohmann deleted the OCPBUGS-19453 branch March 27, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

Assignees

No one assigned

Labels

branch/enterprise-4.12 branch/enterprise-4.13 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

6 participants

@jldohmann @openshift-ci-robot @ocpdocs-previewbot @bergerhoffer @rioliu-rh @openshift-cherrypick-robot