Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: RHDEVDOCS-5960 - JIRA link updates for GitOps releases 1.9.4, 1.10.2, and 1.11.1 #73216

Closed
wants to merge 1 commit into from
Closed

WIP: RHDEVDOCS-5960 - JIRA link updates for GitOps releases 1.9.4, 1.10.2, and 1.11.1 #73216

wants to merge 1 commit into from

Conversation

Dhruv-Soni11
Copy link
Contributor

@Dhruv-Soni11 Dhruv-Soni11 commented Mar 15, 2024 •
edited

Version(s):

Must be CP'ed to GitOps 1.11, 1.10, and 1.9 releases

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5960

Link to docs preview:

https://73216--docspreview.netlify.app/openshift-gitops/latest/release_notes/gitops-release-notes

SME review: @reginapizza
QE review: @varshab1210
Peer review: @Srivaralakshmi

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 15, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 15, 2024 •
edited

🤖 Updated build preview is available at:
https://73216--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/37984

@Dhruv-Soni11 Dhruv-Soni11 changed the title JIRA link updates for 1.9.4, 1.10.2, and 1.11.1 releases WIP: JIRA link updates for 1.9.4, 1.10.2, and 1.11.1 releases Mar 15, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2024
@reginapizza
Copy link
Contributor

reginapizza commented Mar 15, 2024 •
edited

LGTM but does since this has been changed to RHSA, does it need the type of heading in the doc that says the errata number? (like here in 1.10.1?)

@Dhruv-Soni11
Copy link
Contributor Author

LGTM but does since this has been changed to RHSA, does it need the type of heading in the doc that says the errata number? (like here in 1.10.1?)

Yeah, I think once we get those details - we can add it here. WDYT @Srivaralakshmi?

@Srivaralakshmi
Copy link
Member

LGTM but does since this has been changed to RHSA, does it need the type of heading in the doc that says the errata number? (like here in 1.10.1?)

Yeah, I think once we get those details - we can add it here. WDYT @Srivaralakshmi?

  • 1.9.4 - RHSA-2024:0691-02
  • 1.10.2 - RHSA-2024:0692-02
  • 1.11.1 - RHSA-2024:0689-07

Srivaralakshmi
Srivaralakshmi reviewed Mar 15, 2024
View reviewed changes
Copy link
Member

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruv-Soni11 Good work! Please add the errata updates section as discussed. Please keep the XX and NN parts in the links. Otherwise, the link will throw errors and PR builds won't pass.

The rest of the content LGTM. Thank you!

@Dhruv-Soni11 Dhruv-Soni11 changed the title WIP: JIRA link updates for 1.9.4, 1.10.2, and 1.11.1 releases WIP: RHDEVDOCS-5960 - JIRA link updates for GitOps releases 1.9.4, 1.10.2, and 1.11.1 Mar 15, 2024
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 15, 2024
@Dhruv-Soni11
Copy link
Contributor Author

@Dhruv-Soni11 Good work! Please add the errata updates section as discussed. Please keep the XX and NN parts in the links. Otherwise, the link will throw errors and PR builds won't pass.

The rest of the content LGTM. Thank you!

Hi @Srivaralakshmi - I have added the content for the Errata updates. Please check.

Srivaralakshmi
Srivaralakshmi reviewed Mar 15, 2024
View reviewed changes
Copy link
Member

@Srivaralakshmi Srivaralakshmi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruv-Soni11 PTAL at my comment. The rest is LGTM. Please ping me when the PR is ready for another look. TY!

modules/gitops-release-notes-1-10-2.adoc Outdated Show resolved Hide resolved
@Srivaralakshmi Srivaralakshmi added peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 15, 2024
@reginapizza
Copy link
Contributor

hey @Dhruv-Soni11, just checked on this jira and in the comments you'll see I was able to confirm that the errata advisory numbers would stay the same as the previous release, so you should be able to use the same ones :)

@Srivaralakshmi Srivaralakshmi added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 15, 2024
@reginapizza
Copy link
Contributor

@Srivaralakshmi can you explain where the -02 and -07 are coming from after the XXXX:nnnn? In our release notes previously it only shows the numbers as XXXX:nnnn without any numbers afterwards

@Srivaralakshmi
Copy link
Member

Srivaralakshmi commented Mar 18, 2024 •
edited

@Srivaralakshmi can you explain where the -02 and -07 are coming from after the XXXX:nnnn? In our release notes previously it only shows the numbers as XXXX:nnnn without any numbers afterwards

@reginapizza Of course. If you see in the errata titles, it is mentioned as is with -02 and -07. Thank you!

@reginapizza
Copy link
Contributor

@Srivaralakshmi the errata titles where though? Everywhere I'm looking (like here for example) none of the errata titles have a format like that, and I don't see anywhere in our release notes for security advisories with anything like that.

@Srivaralakshmi
Copy link
Member

@Srivaralakshmi the errata titles where though? Everywhere I'm looking (like here for example) none of the errata titles have a format like that, and I don't see anywhere in our release notes for security advisories with anything like that.

@reginapizza I am not sure whether it is okay to share the errata screenshot in GH. I have shared it in the slack. PTAL. TY!

@Dhruv-Soni11 Dhruv-Soni11 force-pushed the RHDEVDOCS-5960 branch 2 times, most recently from 7bd8956 to 41f14b8 Compare March 22, 2024 16:30
varshab1210
varshab1210 reviewed Mar 22, 2024
View reviewed changes
modules/gitops-release-notes-1-10-2.adoc Outdated Show resolved Hide resolved
modules/gitops-release-notes-1-11-1.adoc Outdated Show resolved Hide resolved
modules/gitops-release-notes-1-9-4.adoc Outdated Show resolved Hide resolved
@Dhruv-Soni11
Copy link
Contributor Author

@reginapizza and @varshab1210 - Fixed the changes as per your inputs. PTAL and provide an LGTM if everything is ok.

@varshab1210
Copy link

LGTM

@reginapizza
Copy link
Contributor

LGTM!

@mramendi
Copy link
Contributor

Unfortunately, this does not work as a cp to GitOps 1.9 and 1.10. I will create the additional PRs myself.

This was referenced Mar 22, 2024
Merged
Merged
Merged
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Dhruv-Soni11
Copy link
Contributor Author

Closing this PR as content has already been merged by @mramendi in the following PR as I was away on PTO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varshab1210 varshab1210 varshab1210 left review comments

@Srivaralakshmi Srivaralakshmi Srivaralakshmi left review comments

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Dhruv-Soni11 @ocpdocs-previewbot @reginapizza @Srivaralakshmi @varshab1210 @mramendi @openshift-merge-robot