Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHDEVDOCS 5960 Errata RN update for GitOps 1.9.4, 1.10.2, 1.11.1 - 1.11 and gitops-docs #73653

Merged

Conversation

mramendi
Copy link
Contributor

@mramendi mramendi commented Mar 22, 2024

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 22, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 22, 2024

🤖 Mon Mar 25 15:14:08 - Prow CI generated the docs preview:
https://73653--ocpdocs-pr.netlify.app

@mramendi
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 22, 2024
@agantony
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 25, 2024
Copy link
Contributor

@agantony agantony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggestions for your consideration; overall lgtm!

modules/gitops-release-notes-1-10-2.adoc Outdated Show resolved Hide resolved
modules/gitops-release-notes-1-10-2.adoc Outdated Show resolved Hide resolved
modules/gitops-release-notes-1-11-1.adoc Outdated Show resolved Hide resolved
modules/gitops-release-notes-1-11-1.adoc Outdated Show resolved Hide resolved
modules/gitops-release-notes-1-9-4.adoc Outdated Show resolved Hide resolved
[id="fixed-issues-1-9-4_{context}"]
== Fixed issues

The following issue has been resolved in the current release:

* Before this update, all versions of Argo CD `v2.7.2` and later were vulnerable to cross-server request forgery (CSRF) attacks. As a result, Argo CD would accept non-GET requests even if they did not specify their content type. This update fixes the issue by upgrading the Argo CD to `v.2.7.16` and patching this vulnerability in the Argo CD API. link:https://issues.redhat.com/browse/GITOPS-3921[GITOPS-3921]
* Before this update, all versions of Argo CD `v2.7.2` and later were vulnerable to cross-server request forgery (CSRF) attacks. As a result, Argo CD would accept non-GET requests even if they did not specify their content type. This update fixes the issue by upgrading the Argo CD version to `v.2.7.16` and patching this vulnerability in the Argo CD API. link:https://issues.redhat.com/browse/GITOPS-4218[GITOPS-4218]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same suggestion as above

@agantony
Copy link
Contributor

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 25, 2024
@mramendi mramendi force-pushed the RHDEVDOCS-5960-1.11-main branch 2 times, most recently from 43de9c0 to 491d2f0 Compare March 25, 2024 14:50
@mramendi
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 25, 2024
@mramendi
Copy link
Contributor Author

/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 25, 2024
@mramendi
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 25, 2024
Copy link

openshift-ci bot commented Mar 25, 2024

@mramendi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@JoeAldinger JoeAldinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If all of this documentation is being added to previously published docs then this needs to go through CM.

@JoeAldinger JoeAldinger added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 25, 2024
@JoeAldinger JoeAldinger added this to the Continuous Release milestone Mar 25, 2024
@JoeAldinger JoeAldinger merged commit 18a8d5a into openshift:gitops-docs-1.11 Mar 25, 2024
3 checks passed
@JoeAldinger
Copy link
Contributor

/cherrypick gitops-docs-1.11

@openshift-cherrypick-robot

@JoeAldinger: base branch (gitops-docs-1.11) needs to differ from target branch (gitops-docs-1.11)

In response to this:

/cherrypick gitops-docs-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants