Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EUS update format fix #75885

Merged
merged 1 commit into from
May 13, 2024
Merged

EUS update format fix #75885

merged 1 commit into from
May 13, 2024

Conversation

skopacz1
Copy link
Contributor

@skopacz1 skopacz1 commented May 13, 2024

Version(s): 4.14+

This PR fixes a small formatting error introduced in this line of #75655 which unintentionally removes the nesting of that step's example output, and shows an unwanted + in the rendered docs.

QE: N/A for typo/formatting fix

Live doc: EUS-to-EUS update using the CLI

Preview: EUS-to-EUS update using the CLI

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 13, 2024
@skopacz1 skopacz1 added this to the Continuous Release milestone May 13, 2024
@ocpdocs-previewbot
Copy link

🤖 Mon May 13 19:50:34 - Prow CI generated the docs preview:

https://75885--ocpdocs-pr.netlify.app/openshift-enterprise/latest/updating/updating_a_cluster/eus-eus-update.html

Copy link

openshift-ci bot commented May 13, 2024

@skopacz1: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@skopacz1 skopacz1 added the peer-review-needed Signifies that the peer review team needs to review this PR label May 13, 2024
@rh-tokeefe
Copy link
Contributor

LGTM

@rh-tokeefe
Copy link
Contributor

/label peer-review-done

@rh-tokeefe
Copy link
Contributor

/label merge-review-needed

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR merge-review-needed Signifies that the merge review team needs to review this PR labels May 13, 2024
@rh-tokeefe
Copy link
Contributor

/remove-label peer-review-in-progress

Copy link

openshift-ci bot commented May 13, 2024

@rh-tokeefe: Those labels are not set on the issue: peer-review-in-progress

In response to this:

/remove-label peer-review-in-progress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rh-tokeefe
Copy link
Contributor

/remove-label peer-review-needed

@openshift-ci openshift-ci bot removed the peer-review-needed Signifies that the peer review team needs to review this PR label May 13, 2024
@skopacz1 skopacz1 merged commit 257b567 into openshift:main May 13, 2024
3 checks passed
@skopacz1
Copy link
Contributor Author

/cherrypick enterprise-4.14

@skopacz1
Copy link
Contributor Author

/cherrypick enterprise-4.15

@skopacz1
Copy link
Contributor Author

/cherrypick enterprise-4.16

@openshift-cherrypick-robot

@skopacz1: new pull request created: #75894

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@skopacz1: new pull request created: #75895

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@skopacz1: new pull request created: #75896

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@skopacz1 skopacz1 removed the merge-review-needed Signifies that the merge review team needs to review this PR label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants