Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1885249: Replace glog with klog v2 #59

Merged
merged 2 commits into from Oct 7, 2020
Merged

Bug 1885249: Replace glog with klog v2 #59

merged 2 commits into from Oct 7, 2020

Conversation

paulfantom
Copy link
Contributor

This should have been about updating from klog v1 to v2 but sadly we weren't even at v1.

/cc @openshift/openshift-team-monitoring

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Oct 7, 2020
@openshift-ci-robot
Copy link
Contributor

@paulfantom: This pull request references Bugzilla bug 1885249, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1885249: Replace glog with klog v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 7, 2020
simonpasquier
simonpasquier reviewed Oct 7, 2020
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paulfantom, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [paulfantom,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 0e59c0d into openshift:master Oct 7, 2020
@openshift-ci-robot
Copy link
Contributor

@paulfantom: All pull requests linked via external trackers have merged:

Bugzilla bug 1885249 has been moved to the MODIFIED state.

In response to this:

Bug 1885249: Replace glog with klog v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking added a commit to wking/openshift-state-metrics that referenced this pull request Oct 7, 2020
@wking
Revert "Merge pull request openshift#59 from paulfantom/klog"
d0bcce8 
This reverts commit 0e59c0d,
reversing changes made to 041528b.
The 'logtostderr' lookups were segfaulting [1]:

  goroutine 1 [running]:
  github.com/openshift/openshift-state-metrics/pkg/options.(*Options).AddFlags(0xc00020bf40)
  	/go/src/github.com/openshift/openshift-state-metrics/pkg/options/options.go:44 +0x104
  main.main()
  	/go/src/github.com/openshift/openshift-state-metrics/main.go:46 +0xba

leading to:

  level=error msg="Cluster operator monitoring Degraded is True with UpdatingopenshiftStateMetricsFailed: Failed to rollout the stack. Error: running task Updating openshift-state-metrics failed: reconciling openshift-state-metrics Deployment failed: updating Deployment object failed: waiting for DeploymentRollout of openshift-monitoring/openshift-state-metrics: got 1 unavailable replicas"

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1886111#c1
@wking wking mentioned this pull request Oct 7, 2020
Merged
openshift-merge-robot added a commit that referenced this pull request Oct 7, 2020
@openshift-merge-robot
Merge pull request #61 from wking/revert-klog2
c8f9787 
Bug 1886111: Revert "Merge pull request #59 from paulfantom/klog"
paulfantom added a commit to paulfantom/openshift-state-metrics that referenced this pull request Oct 8, 2020
@paulfantom
Bug 1885249: Replace glog with klog v2
fbe439a 
openshift#59 was lacking
klog flag initialization. This is added now and application doesn't
panic on start
@paulfantom paulfantom mentioned this pull request Oct 8, 2020
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Oct 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

Assignees

@simonpasquier simonpasquier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paulfantom @openshift-ci-robot @simonpasquier @openshift-merge-robot