New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1885249: Replace glog with klog v2 #62
Bug 1885249: Replace glog with klog v2 #62
Conversation
openshift#59 was lacking klog flag initialization. This is added now and application doesn't panic on start
@paulfantom: This pull request references Bugzilla bug 1885249, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@paulfantom: This pull request references Bugzilla bug 1885249, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
klog initialization was taken directly from kube-state-metrics: https://github.com/kubernetes/kube-state-metrics/blob/master/pkg/options/options.go#L66-L70 |
/lgtm |
great catch re: initialization 🎉 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paulfantom, s-urbaniak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@paulfantom: All pull requests linked via external trackers have merged: Bugzilla bug 1885249 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
#59 was lacking klog flag initialization. This is added now in https://github.com/openshift/openshift-state-metrics/pull/62/files#diff-13239385e6d7a767c098bcb7a8d2dd03R43-R46 and the application doesn't panic on start