New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1992677: validate maxocpversion to have major.minor format #169
Bug 1992677: validate maxocpversion to have major.minor format #169
Conversation
Signed-off-by: Ankita Thomas <ankithom@redhat.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 7c2f004129b037333c4fe29ec5ac94b5e1247564
…ft#146) Signed-off-by: Ankita Thomas <ankithom@redhat.com> Upstream-repository: api Upstream-commit: 01ed866fe519bd71d8550b3f1a411f819325c422
…ft#147) Signed-off-by: Ankita Thomas <ankithom@redhat.com> Upstream-repository: api Upstream-commit: 6db422fda8df2f7872a493dd696152eaf2e8a4da
@ankitathomas: This pull request references Bugzilla bug 1994038, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankitathomas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retitle Bug 1992677: validate maxocpversion to have major.minor format |
@ankitathomas: This pull request references Bugzilla bug 1992677, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/bugzilla cc-qa |
@jianzhangbjz: This pull request references Bugzilla bug 1992677, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/hold cancel |
/test e2e-aws-olm |
1 similar comment
/test e2e-aws-olm |
Our verify job is broken, see #171 /override ci/prow/verify |
@kevinrizza: Overrode contexts on behalf of kevinrizza: ci/prow/verify In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ankitathomas: All pull requests linked via external trackers have merged: Bugzilla bug 1992677 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-4.8 |
@timflannagan: #169 failed to apply on top of branch "release-4.8":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…t#169) This PR implements a custom unmarshaller for the CatalogSourceSpec.UpdateStrategy. When a value that cannot be unmarshalled to *metav1.Duration was being passed to UpdateStrategy.RegistryPoll.Interval, the catalogSource sync loops in the catalog operator was stuck in an infinite loop instead of backing off and performing other syncs. The custom unmarshaller tries to unmarshall the input to the field to *metav1.Duration, and if it fails, it sets a default value of 15m for the field. Otherwise it accepts the value passed to the field. Upstream-repository: api Upstream-commit: 7c97612f258921a973da23fb55dcd77892401be4
…t#169) This PR implements a custom unmarshaller for the CatalogSourceSpec.UpdateStrategy. When a value that cannot be unmarshalled to *metav1.Duration was being passed to UpdateStrategy.RegistryPoll.Interval, the catalogSource sync loops in the catalog operator was stuck in an infinite loop instead of backing off and performing other syncs. The custom unmarshaller tries to unmarshall the input to the field to *metav1.Duration, and if it fails, it sets a default value of 15m for the field. Otherwise it accepts the value passed to the field. Upstream-repository: api Upstream-commit: 7c97612f258921a973da23fb55dcd77892401be4
…t#169) This PR implements a custom unmarshaller for the CatalogSourceSpec.UpdateStrategy. When a value that cannot be unmarshalled to *metav1.Duration was being passed to UpdateStrategy.RegistryPoll.Interval, the catalogSource sync loops in the catalog operator was stuck in an infinite loop instead of backing off and performing other syncs. The custom unmarshaller tries to unmarshall the input to the field to *metav1.Duration, and if it fails, it sets a default value of 15m for the field. Otherwise it accepts the value passed to the field. Upstream-repository: api Upstream-commit: 7c97612f258921a973da23fb55dcd77892401be4
…t#169) This PR implements a custom unmarshaller for the CatalogSourceSpec.UpdateStrategy. When a value that cannot be unmarshalled to *metav1.Duration was being passed to UpdateStrategy.RegistryPoll.Interval, the catalogSource sync loops in the catalog operator was stuck in an infinite loop instead of backing off and performing other syncs. The custom unmarshaller tries to unmarshall the input to the field to *metav1.Duration, and if it fails, it sets a default value of 15m for the field. Otherwise it accepts the value passed to the field. Upstream-repository: api Upstream-commit: 7c97612f258921a973da23fb55dcd77892401be4
…t#169) This PR implements a custom unmarshaller for the CatalogSourceSpec.UpdateStrategy. When a value that cannot be unmarshalled to *metav1.Duration was being passed to UpdateStrategy.RegistryPoll.Interval, the catalogSource sync loops in the catalog operator was stuck in an infinite loop instead of backing off and performing other syncs. The custom unmarshaller tries to unmarshall the input to the field to *metav1.Duration, and if it fails, it sets a default value of 15m for the field. Otherwise it accepts the value passed to the field. Upstream-repository: api Upstream-commit: 7c97612f258921a973da23fb55dcd77892401be4
…t#169) This PR implements a custom unmarshaller for the CatalogSourceSpec.UpdateStrategy. When a value that cannot be unmarshalled to *metav1.Duration was being passed to UpdateStrategy.RegistryPoll.Interval, the catalogSource sync loops in the catalog operator was stuck in an infinite loop instead of backing off and performing other syncs. The custom unmarshaller tries to unmarshall the input to the field to *metav1.Duration, and if it fails, it sets a default value of 15m for the field. Otherwise it accepts the value passed to the field. Upstream-repository: api Upstream-commit: 7c97612f258921a973da23fb55dcd77892401be4
…t#169) This PR implements a custom unmarshaller for the CatalogSourceSpec.UpdateStrategy. When a value that cannot be unmarshalled to *metav1.Duration was being passed to UpdateStrategy.RegistryPoll.Interval, the catalogSource sync loops in the catalog operator was stuck in an infinite loop instead of backing off and performing other syncs. The custom unmarshaller tries to unmarshall the input to the field to *metav1.Duration, and if it fails, it sets a default value of 15m for the field. Otherwise it accepts the value passed to the field. Upstream-repository: api Upstream-commit: 7c97612f258921a973da23fb55dcd77892401be4
…t#169) This PR implements a custom unmarshaller for the CatalogSourceSpec.UpdateStrategy. When a value that cannot be unmarshalled to *metav1.Duration was being passed to UpdateStrategy.RegistryPoll.Interval, the catalogSource sync loops in the catalog operator was stuck in an infinite loop instead of backing off and performing other syncs. The custom unmarshaller tries to unmarshall the input to the field to *metav1.Duration, and if it fails, it sets a default value of 15m for the field. Otherwise it accepts the value passed to the field. Upstream-repository: api Upstream-commit: 7c97612f258921a973da23fb55dcd77892401be4
…t#169) This PR implements a custom unmarshaller for the CatalogSourceSpec.UpdateStrategy. When a value that cannot be unmarshalled to *metav1.Duration was being passed to UpdateStrategy.RegistryPoll.Interval, the catalogSource sync loops in the catalog operator was stuck in an infinite loop instead of backing off and performing other syncs. The custom unmarshaller tries to unmarshall the input to the field to *metav1.Duration, and if it fails, it sets a default value of 15m for the field. Otherwise it accepts the value passed to the field. Upstream-repository: api Upstream-commit: 7c97612f258921a973da23fb55dcd77892401be4
…t#169) This PR implements a custom unmarshaller for the CatalogSourceSpec.UpdateStrategy. When a value that cannot be unmarshalled to *metav1.Duration was being passed to UpdateStrategy.RegistryPoll.Interval, the catalogSource sync loops in the catalog operator was stuck in an infinite loop instead of backing off and performing other syncs. The custom unmarshaller tries to unmarshall the input to the field to *metav1.Duration, and if it fails, it sets a default value of 15m for the field. Otherwise it accepts the value passed to the field. Upstream-repository: api Upstream-commit: 7c97612f258921a973da23fb55dcd77892401be4
…t#169) This PR implements a custom unmarshaller for the CatalogSourceSpec.UpdateStrategy. When a value that cannot be unmarshalled to *metav1.Duration was being passed to UpdateStrategy.RegistryPoll.Interval, the catalogSource sync loops in the catalog operator was stuck in an infinite loop instead of backing off and performing other syncs. The custom unmarshaller tries to unmarshall the input to the field to *metav1.Duration, and if it fails, it sets a default value of 15m for the field. Otherwise it accepts the value passed to the field. Upstream-repository: api Upstream-commit: 7c97612f258921a973da23fb55dcd77892401be4
…t#169) This PR implements a custom unmarshaller for the CatalogSourceSpec.UpdateStrategy. When a value that cannot be unmarshalled to *metav1.Duration was being passed to UpdateStrategy.RegistryPoll.Interval, the catalogSource sync loops in the catalog operator was stuck in an infinite loop instead of backing off and performing other syncs. The custom unmarshaller tries to unmarshall the input to the field to *metav1.Duration, and if it fails, it sets a default value of 15m for the field. Otherwise it accepts the value passed to the field. Upstream-repository: api Upstream-commit: 7c97612f258921a973da23fb55dcd77892401be4
…t#169) This PR implements a custom unmarshaller for the CatalogSourceSpec.UpdateStrategy. When a value that cannot be unmarshalled to *metav1.Duration was being passed to UpdateStrategy.RegistryPoll.Interval, the catalogSource sync loops in the catalog operator was stuck in an infinite loop instead of backing off and performing other syncs. The custom unmarshaller tries to unmarshall the input to the field to *metav1.Duration, and if it fails, it sets a default value of 15m for the field. Otherwise it accepts the value passed to the field. Upstream-repository: api Upstream-commit: 7c97612f258921a973da23fb55dcd77892401be4
…t#169) This PR implements a custom unmarshaller for the CatalogSourceSpec.UpdateStrategy. When a value that cannot be unmarshalled to *metav1.Duration was being passed to UpdateStrategy.RegistryPoll.Interval, the catalogSource sync loops in the catalog operator was stuck in an infinite loop instead of backing off and performing other syncs. The custom unmarshaller tries to unmarshall the input to the field to *metav1.Duration, and if it fails, it sets a default value of 15m for the field. Otherwise it accepts the value passed to the field. Upstream-repository: api Upstream-commit: 7c97612f258921a973da23fb55dcd77892401be4
…t#169) This PR implements a custom unmarshaller for the CatalogSourceSpec.UpdateStrategy. When a value that cannot be unmarshalled to *metav1.Duration was being passed to UpdateStrategy.RegistryPoll.Interval, the catalogSource sync loops in the catalog operator was stuck in an infinite loop instead of backing off and performing other syncs. The custom unmarshaller tries to unmarshall the input to the field to *metav1.Duration, and if it fails, it sets a default value of 15m for the field. Otherwise it accepts the value passed to the field. Upstream-repository: api Upstream-commit: 7c97612f258921a973da23fb55dcd77892401be4
…t#169) This PR implements a custom unmarshaller for the CatalogSourceSpec.UpdateStrategy. When a value that cannot be unmarshalled to *metav1.Duration was being passed to UpdateStrategy.RegistryPoll.Interval, the catalogSource sync loops in the catalog operator was stuck in an infinite loop instead of backing off and performing other syncs. The custom unmarshaller tries to unmarshall the input to the field to *metav1.Duration, and if it fails, it sets a default value of 15m for the field. Otherwise it accepts the value passed to the field. Upstream-repository: api Upstream-commit: 7c97612f258921a973da23fb55dcd77892401be4
…t#169) This PR implements a custom unmarshaller for the CatalogSourceSpec.UpdateStrategy. When a value that cannot be unmarshalled to *metav1.Duration was being passed to UpdateStrategy.RegistryPoll.Interval, the catalogSource sync loops in the catalog operator was stuck in an infinite loop instead of backing off and performing other syncs. The custom unmarshaller tries to unmarshall the input to the field to *metav1.Duration, and if it fails, it sets a default value of 15m for the field. Otherwise it accepts the value passed to the field. Upstream-repository: api Upstream-commit: 7c97612f258921a973da23fb55dcd77892401be4
…t#169) This PR implements a custom unmarshaller for the CatalogSourceSpec.UpdateStrategy. When a value that cannot be unmarshalled to *metav1.Duration was being passed to UpdateStrategy.RegistryPoll.Interval, the catalogSource sync loops in the catalog operator was stuck in an infinite loop instead of backing off and performing other syncs. The custom unmarshaller tries to unmarshall the input to the field to *metav1.Duration, and if it fails, it sets a default value of 15m for the field. Otherwise it accepts the value passed to the field. Upstream-repository: api Upstream-commit: 7c97612f258921a973da23fb55dcd77892401be4
…t#169) This PR implements a custom unmarshaller for the CatalogSourceSpec.UpdateStrategy. When a value that cannot be unmarshalled to *metav1.Duration was being passed to UpdateStrategy.RegistryPoll.Interval, the catalogSource sync loops in the catalog operator was stuck in an infinite loop instead of backing off and performing other syncs. The custom unmarshaller tries to unmarshall the input to the field to *metav1.Duration, and if it fails, it sets a default value of 15m for the field. Otherwise it accepts the value passed to the field. Upstream-repository: api Upstream-commit: 7c97612f258921a973da23fb55dcd77892401be4 Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
This PR adds validation to the api to warn on maxOpenShiftVersion with patch or pre-release set, and has olm error on the same.
It also rewords the olm upgrade error for upgrades to a minor version greater than maxOpenShiftVersion for more clarity.