Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using bsdtar for extraction during build #10364

Merged
merged 1 commit into from
Aug 13, 2016

Conversation

joelsmith
Copy link
Contributor

No description provided.

@bparees
Copy link
Contributor

bparees commented Aug 12, 2016

[test]

@bparees
Copy link
Contributor

bparees commented Aug 12, 2016

[testextended][extended:core(builds)]

@bparees
Copy link
Contributor

bparees commented Aug 12, 2016

this seems to have pretty clearly broken binary build functionality :(

@bparees
Copy link
Contributor

bparees commented Aug 12, 2016

failure is:

F0812 15:05:16.451243       1 helpers.go:108] error: build error: unable to extract binary build input, must be a zip, tar, or gzipped tar, or specified as a file: exit status 2

@joelsmith
Copy link
Contributor Author

@bparees I think I have fixed the issue. The shell wanted $0 instead of $1 for -c params. From bash(1):
If the -c option is present, then commands are read from the first non-option argument command_string. If there are arguments after the command_string, they are assigned to the positional parameters, starting with $0
I made a little test program that only extracts and that change seemed to fix it, so I expect this time things will go better.

@joelsmith
Copy link
Contributor Author

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin testextended up to 4beb260

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin_extended/427/) (Extended Tests: core(builds))

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 4beb260

@bparees
Copy link
Contributor

bparees commented Aug 12, 2016

@smarterclayton tested this syntax locally using a zip archive, tar archive, tar.gz archive, and tar.bz2 archive, all worked.

thanks @joelsmith!

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 12, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7892/) (Image: devenv-rhel7_4817)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 4beb260

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7875/)

@openshift-bot openshift-bot merged commit 1eee224 into openshift:master Aug 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants