Fix hack/test-cmd.sh running inside of the hack/env #11516
Conversation
Needs to be debugged in the container environment
smarterclayton
force-pushed
the
remaining_containerized_fixes
branch
from
dfe8489
to
853ccbe
Compare
Should not call NewFactory() anywhere outside of the command initialization, causes hangs when stdin is not open because it goes into the PromptingLoader path. See openshift#11513
|
Evaluated for origin test up to 853ccbe |
| templocation=$( mktemp ) | ||
| chmod uga-w "${templocation}" | ||
| os::cmd::expect_failure_and_text "oc login '${KUBERNETES_MASTER}' -u test -p test '--config=${templocation}' --insecure-skip-tls-verify" 'KUBECONFIG is set to a file that cannot be created or modified' | ||
| # Does not work inside of a container, determine why and reenable |
There was a problem hiding this comment.
@juanvallejo this test doesn't work inside of a container - since this blocks us making some changes to the build system I'm going to disable the test. Can you open a follow up to restore it and make a test that works even if the user is root?
There was a problem hiding this comment.
@smarterclayton will do
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10541/) (Base Commit: 4d9c078) |
|
[merge] |
|
@smarterclayton need to remove the last paragraph of |
|
Can you rebase your change on this after it merges? |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10541/) (Image: devenv-rhel7_5236) |
|
Evaluated for origin merge up to 853ccbe |
|
@smarterclayton ok, will do. |
[test]