UPSTREAM: 47281: Update devicepath with filepath.Glob result #14565
Conversation
If iscsiTransport is not tcp, iSCSI plugin tries to find devicepath using filepath.Glob but never updates devicepath with the filepath.Glob result. This patch fixes the problem.
|
lgtm |
|
[test] |
|
[test] |
|
@rootfs |
|
/cc @rootfs |
|
[test] |
|
[merge] |
|
@childsb can you merge? |
|
[merge] |
| if err == nil { | ||
| return true | ||
| } | ||
| if err != nil && !os.IsNotExist(err) { |
There was a problem hiding this comment.
How did no one point out this err != nil is redundant? Don't have to fix it here, but we should fix this upstream.
There was a problem hiding this comment.
I'll push to remove that redundant "error != nil" check to upstream.
|
[test] |
|
Evaluated for origin test up to cf75600 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2292/) (Base Commit: d1e5be5) (PR Branch Commit: cf75600) |
|
[severity:bug][merge] |
|
Evaluated for origin merge up to cf75600 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1032/) (Base Commit: 7bee838) (PR Branch Commit: cf75600) (Extended Tests: bug) (Image: devenv-rhel7_6374) |
Automatic merge from submit-queue (batch tested with PRs 47619, 47951, 46260, 48277) iSCSi plugin: Remove redundant nil check **What this PR does / why we need it**: This patch is for cleanup of redundant nil check in iSCSI plugin. This was mentioned at the code review on origin github thread. openshift/origin#14565 **Which issue this PR fixes** **Special notes for your reviewer**: **Release note**: ``` NONE ```
If iscsiTransport is not tcp, iSCSI plugin tries to
find devicepath using filepath.Glob but never updates
devicepath with the filepath.Glob result.
This patch fixes the problem.