Ensure CNI dir exists before writing openshift CNI configuration under CNI dir #15064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@openshift/networking @dcbw PTAL |
rajatchopra
approved these changes
Jul 5, 2017
pkg/sdn/plugin/node.go
Outdated
| @@ -326,13 +332,17 @@ func (node *OsdnNode) Start() error { | |||
| } | |||
| } | |||
|
|
|||
| if err := os.MkdirAll(CNI_DIR_PATH, os.ModePerm); err != nil { | |||
There was a problem hiding this comment.
FileMode could be 0755 maybe?
pravisankar
force-pushed
the
ensure-cnidir-exits
branch
from
aab5ed7
to
4de16b6
Compare
|
[test] |
pkg/sdn/plugin/node.go
Outdated
| @@ -38,6 +39,11 @@ import ( | |||
| kexec "k8s.io/kubernetes/pkg/util/exec" | |||
| ) | |||
|
|
|||
| const ( | |||
| CNI_DIR_PATH = "/etc/cni/net.d" | |||
There was a problem hiding this comment.
We don't do constants like this - if this is only used in this package, should be camelCase
…r CNI dir Found this issue on RHEL containerized openshift install.
pravisankar
force-pushed
the
ensure-cnidir-exits
branch
from
4de16b6
to
23368fb
Compare
|
Changed constants to |
|
[test] |
|
Evaluated for origin test up to 23368fb |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3096/) (Base Commit: c52694b) (PR Branch Commit: 23368fb) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this issue on RHEL containerized openshift install.
Fixes: #14661
Fixes: #15147