Remove download of goversioninfo #15218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This broke the origin release because the binary is not in the release image. |
openshift-merge-robot
added a commit
that referenced
this pull request
Jul 30, 2017
Automatic merge from submit-queue Require goversioninfo for Windows cross builds Changes in #15218 caused build-cross to now fail during the release process. goversioninfo has to be in the release image. @jupierce @fabianofranz we should be more cautious about introducing new dependencies to the build in the future. Better testing prior (including running a release build) would probably have caught this. Someone also needs to add build-cross to the additional jobs that can be run and put into the post build step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wrong about brew. Any traffic out for build is prohibited. I've gone through the pain of creating an RPM for this package.
@stevekuznetsov @smarterclayton